GithubHelp home page GithubHelp logo

dan503 / mq-js Goto Github PK

View Code? Open in Web Editor NEW
6.0 1.0 3.0 4.94 MB

Media queries in JavaScript inspired by the mq-scss Sass mixin

Home Page: https://dan503.github.io/mq-js/

License: MIT License

JavaScript 45.34% TypeScript 7.57% Pug 25.71% SCSS 21.38%
mq-scss javascript media query responsive breakpoints

mq-js's Issues

Add TypeScript support

The world is moving to TypeScript.

This is still a useful library so it needs to keep up.

I've already made a start on writing out the Types needed for this:

type Callback = (screenSize: number) => void

type SimpleMq<BP> = (bp: keyof BP, cb?: Callback) => boolean
type ComplexMq<BP> = (bp1: keyof BP, bp2: keyof BP, cb?: Callback) => boolean
type ReactToCB = (isActive: boolean, screenSize: number) => void

export interface MqJs<BP extends object> {
	/** Returns `true` if the window size is **less than** the breakpoint size */
	min: SimpleMq<BP>,
	/** Returns `true` if the window size is **greater than** the breakpoint size */
	max: SimpleMq<BP>,
	/** Returns `true` if the window size is **greater than smaller** breakpoint but **less than the larger** breakpoint */
	inside: ComplexMq<BP>,
	/** Returns `true` if the window size is **less than the smaller breakpoint** or **greater than the larger** breakpoint */
	outside: ComplexMq<BP>,
	/** Runs a callback function every time `testMQ` changes from returning `true` to returning `false` */
	reactTo: (testMQ: () => boolean, cb: ReactToCB) => void
}

mq-js not properly compatible with mq-scss when em conversion is turned on

If someone is using mq-scss in em conversion mode and the website user increases their default browser font size, mq-scss and mq-js will get out of sync with one another.

mq-js has no em conversion functionality so the only way around this is to turn off em conversion in mq-scss at the moment.

mq-js needs an em conversion mode. I plan to do this by using window.matchMedia rather than gathering data on the window dimensions and doing the math manually. This is the better way for the plugin to work anyway.

Use Cypress for unit testing

I have a shitty unit testing solution at the moment.

It does the job but using Cypress for this would be immensely better.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.