danbourdier / triharder Goto Github PK

Great job on your routes! Here are my reviews:

Backend
Looks good so far

frontend

• is /dashboard the page that shows all the routes? If so, I think we can show actvity_feed on your dashboard. That way you don't need to create another route for activity_feed

Hey Daniel! Great job on your design doc in a short period of time! Here are my reviews:

MVPs

• please follow a/A MVP guidelines https://open.appacademy.io/learn/swe-in-person-nyc/full-stack-project/mvp-checklist as follows:

MapMyRun

• Making running routes using map

• Friending

• Comments on runs

• Dashboard that tracks completed runs

• Bonus: cheers for friends

• Bonus: Search for runs by location

• Bonus: goals

• Search MVP is a bonus quest. Take Search off your 3rd MVP.

• put Friends MVP as your 4th.

• Dashboard that tracks completed runs is your profile.

• Be specific what is gear MVP for. If it's not a functionality of the original app, let's think about it later until we finish most main features

Schema

• Workouts table can break into two tables routes and workouts. Reorganize the table. The main functionality of MapMyRun is tracking the routes. routes should be the main table and workouts table is for saving the completed route data, with foreign keys of user_id and route_id
• I still don't understand what gear is for(I guess it's for foorwear?). Let's consider this until we finish all main functionalities. We can discuss this more later during our full stack meeting.
• If we have workouts table, we might not need status table.
• likes: this is bonus feature, so we don't have to put too much thoughts on this yet. The best example for like is Art API project. This table needs to be rewritten but let's put (bonus) on it and think about it later.
• comments: get rid of liker_id.
• comments: think about on which posts you are adding comment functionality. If you are adding comments on both routes, workouts and status, consider to use polymorphism.

state

• please change your state based on your changes on schema

schema

• please put your mvp 6.create account, login, logout... as your 1st MVP. (This is what you are going to do on the first day of fullstack project)
• combine your workout and status tables into one table. (choose one of the names)

state

• please reflect the above changed on the state. ex. now that workout and status tables are in one table, their states should be one too.