danfinlay / js-eth-personal-sign-examples

A simple web UI for demonstrating the provider API for signing & recovering messages.

JS Ethereum Signature Example

This repository should be considered deprecated! It has been forked and is being maintained to a much higher quality as the MetaMask e2e test dapp.

Simplest possible signature examples, for use with MetaMask.

Live Demo Here

js-eth-personal-sign-examples's Issues

Demo uses legacy web3 API

If would be cool if you get a chance to update the demo site for this repo so it doesn't use the legacy web3 API. Thanks!

Mostly since this MetaMask docs page links to this repo

Related issue MetaMask/metamask-docs#212

bundle.js:1 Uncaught SyntaxError: Identifier 'Buffer' has already been declared

Hi

I tried to rebuild the example using these commands
npm install
npm run-script build

It failed with the error "Cannot find module 'babel-runtime/regenerator" which I fixed by npm install --save-dev babel-runtime

Afterwhich, I run the example through a python http server python3 -m http.server and gotten the this error on the browser console.
Uncaught SyntaxError: Identifier 'Buffer' has already been declared
at s (bundle.js:1)
at bundle.js:1
at Object. (bundle.js:4)
at Object.1.buffer (bundle.js:355)
at s (bundle.js:1)
at e (bundle.js:1)
at bundle.js:1

BTW, if I use the existing bundle.js (and not rebuild it) - it works.

Tryed demo on page an it gives: Cannot read property 'eth' of undefined

bundle.js:formatted:55 Uncaught TypeError: Cannot read property 'eth' of undefined
at HTMLButtonElement. (bundle.js:formatted:55)

will fail if addresses are not the same case, such as from metamask

Someone can easily spend too much time trying to figure out why the signing verification is failing. The recovered address can be a different case than the 'from' address. Easy solution is to "toLowerCase()" the assignment to the 'from' variable.

e.slice is not a function when running locally and trying to run eth_sign

I ran this locally with python -m SimpleHTTPServer 8000 and navigated to localhost:8000. When trying to run eth_sign, I get the following error:

MetaMask - RPC Error: e.slice is not a function {code: -32603, message: "e.slice is not a function", data: {…}}

BNB

https://

Throws if signTypedData_v3 is used on non-mainnet

Cannot read property 'accounts' of undefined

Hi all . After clicking on button to get signature I am getting an error look like this

 Cannot read property 'accounts' of undefined at HTMLButtonElement.<anonymous> (bundle.js:25873)

All of those buttons not working. The same error message!

npm run build fails

I would like to experiment with this by making some changes. Not having luck trying to build it.
node 8.9.4 and npm 5.6.0 on macOS Mojave.

ethsign git:(master) ✗ npm run build

> [email protected] build /Users/vamsee/Development/blockchain/pulse/samples/js-eth-personal-sign-examples
> browserify -t brfs index.js -o bundle.js

Error: Cannot find module 'babel-runtime/regenerator' from '/Users/vamsee/Development/blockchain/pulse/samples/js-eth-personal-sign-examples/node_modules/ethjs-query/lib'
    at /usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /usr/local/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:152:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build: `browserify -t brfs index.js -o bundle.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.