danielkiwi / skaterxl-modding Goto Github PK
View Code? Open in Web Editor NEWA Collection of Mods for SkaterXL
License: MIT License
A Collection of Mods for SkaterXL
License: MIT License
So whenever i edit a clip, doesn't matter which mode ( freemode, tripod, ect ) the skater gets super shaky. It's just the skater though, everything else is smooth. Scenery, camera follow movement.
I've heard other people having the same issue but i didn't see a bug report yet.
I shouldn't be my pc, specs are way more than needed.
Whatever causes it, i haven't found a fix yet. Thank you.
Mod Name
XLShredReplayEditor
Version numbers
Game version: 2018.3.0.7248423
Mod manager version: 0.20.0.0
XLShredReplayEditor version: 1.3.0
Multiplayer mod version: 0.2.3
Describe the bug
Having both mods enabled at the same time causes the game to crash when connected to a multiplayer game. More specifically the game crashes when the replay editor is recording and at the same time the multiplayer mod is creating the character for another player in the game.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Both mods should be able to work together without crashing the game.
Logfile
I currently don't have this accessible, but the crash log each time reports on "attempting to read an invalid address".
Additional context
I submitted this as a bug report but perhaps it could be regarded as a feature request.
I narrowed down the incompatibility to the moment that the multiplayer mod spawns another player (see https://github.com/silentbaws/XLMultiplayer/blob/master/XLMultiplayer/MultiplayerPlayerController.cs#L445). Each time this happens the new character is created from the main player's skater and board in the following way (I'll exclude the board to which the same happens but this isn't causing issues).
The game crashes as a result of step 1 because one of those monobehaviors is ReplayAudioRecorder, which has an onDisable lifecycle event which closes the memory stream.
I am sure that this is the only point where the mods are incompatible (except for an issue when removing the player, described below) as I modified the multiplayer mod to not disable the ReplayAudioRecorder in step 1, after which the crash when a player joins doesn't occur anymore.
However with the above fix the game crashes when a player is disconnected and his character is removed. I'm not sure why that happens but it would probably require quite some changes in the multiplayer mod to prevent that.
So my question is the following: can this perhaps easily be fixed in the replay editor mod? There might be a few options:
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.