dantaframework / jahiadf Goto Github PK

• Eliminate TODO comments.
• Organize the code in more cohesive blocks: constants, fields, constructor, methods, inner classes.
• It seems that this class is intended to support multiple modes, but this has lead to a large amount of duplicated checking and processing throughout the classes many methods. Consider abstracting mode-related behaviour out of the common behaviour, in order to separate types more cleanly.

See DantaFramework/AEM#11 for suggestions on that similar class.

There is a high degree of copied code between these two classed. Determine if it is possible to promote/abstract any common functionality to Core or another common project.

The last release 080917 the context "list" not works properly, actually we use this feature to create the Main Navigation component.

The following lines has the configuration for the xk-config-json file

{
"xk_componentCategory": [
"list",
"traversedList",
"pageDetails",
"getInternalExternalLink",
"jsonFormatProcess"
],
"xk_pathRefKeyName": "global.rootPath",
"depth": "2",
"xk_depthKeyName": "config.depth",
"xk_extraListPropertyNames": [
"hideInNav",
"subtitle"
],
"linkInternalExternalProperties": [
"global.socialLinkList"
],
"jsonFormatProperties": [
"list.pages",
"global.socialLinkList"
]
}

The lists CPs seem to stop working, at least in my instance. The method for converting weakreferences to URLs is not recognizing the workspace (edit, live) anymore so that the URLs generated by the traversed and curated CPs are just empty strings. The problem it is not in the lists CPs themselves, but in this method:

• ResourceUtils.getResourceNodePath

which is used to translate weakreferences (resource IDs) to URLs. In edit mode, this method returns the URLs as if they were browsed from a page in live mode.

This is very weird because it works perfectly in LayerX version and the code looks the same. I am not sure if this is happening only in my instance or if it is a bug that resulted from the migration to Danta.

See DantaFramework/AEM#8 for suggestions on that suspiciously similar class.

Even better, determine if it is possible to promote the common functionality to Core or another common project, rather than maintaining two implementations.

Code has been commented out, and there are no usages of this class.

Currently all packages in the danta.jahia (danta.jahia.) bundle are being exported, only the following packages should be exported:
danta.jahia.contextprocessors., danta.jahia.services and danta.jahia.