daphneje / restaurant-back-end-server Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 3.0 3.57 MB

Back-end server for restaurant app.

JavaScript 100.00%

restaurant-back-end-server's People

Contributors

Watchers

Forkers

chiamtj kwanboon huzaifatp

restaurant-back-end-server's Issues

Consider using Sequelize Migration

The point of using ORM is so that we do not introduce native SQL language in our project. When we use native database language, it will obstruct us from "changing database". Instead of using postgreSQL.sql, consider using sequelize migration.

Consider using http-status package for http status readability

Check this out: https://www.npmjs.com/package/http-status

Clear separation of responsibilities for controller and service code

service layer should only contain business logics and should not handle HTTP related request, such as status 404 and such. Handle statuses and http responses in controller.

Service layer should be reusable. In this case, if I add a messaging protocol to your project, I cannot reuse your services because they are very http centric.

In a service, when you caught an error, you should always throw it and let the higher stack of code catch that error and produce a proper response. When service layer detected an error, throw it and let HTTP controller or Messaging protocol code to handle that error.

Recommend Projects