darbyjack / voteparty

Give rewards to all online players when the server gets a certain amount of votes! 1.8+

Welcome to VoteParty 👋

Give rewards to all online players when the server gets a certain amount of votes! 1.8+

Author

👤 Glare

• Website: https://glaremasters.me/
• Github: @darbyjack

Get Help

🤝 Contributing

Contributions, issues and feature requests are welcome!
Feel free to check issues page.

Show your support

Give a ⭐️ if this project helped you!

📝 License

Copyright © 2021 darbyjack.
This project is MIT licensed.

voteparty's Issues

Feature request

Spigot name: xdLulux
Version : 1.16.5
Plugin version : 2.26

I was wondering if you could add a placeholder where it will tell you when you can vote again and a config where it will send a message / command to the user every time he can vote

Customizable empty top placeholders.

Add 2 options to customize what is shown by the top placeholders when there's no one in that top.

Add more voting sites to ''Service Names''

Please add this following sites to ''Service Names'' if possible

https://minecraft.buzz/

https://servidoresdeminecraft.es/

Allow chances to take in double not just integers.

Exactly what the title say. Some people want chances like 0.01 or 0.1 instead of just 1 for very rare rewards or stuff like that.

[Feature Request] Allow Receiving Cumulative Vote Rewards While Offline

The check cumulative functions (checkDailyCumulative, checkWeeklyCumulative, etc.) in

VoteParty/src/main/kotlin/me/clip/voteparty/handler/VotesHandler.kt

Line 100 in 01a0d4e

fun checkDailyCumulative(player: Player)

are only called when a player is online due to this check

VoteParty/src/main/kotlin/me/clip/voteparty/listener/VotesListener.kt

Line 53 in 01a0d4e

val online = player.player ?: return

Since the cumulative checks only see if the player has exactly the correct amount of votes, players do not receive cumulative rewards if they were offline for the last vote. This could be fixed in one of two ways:

1. Keep track of the cumulative rewards a player did receive and change the cumulative check to check for greater than or equal to the required amount of votes.
2. Add cumulative rewards to a player's claimable, redeeming them when the player next joins (as shown in this commit ParallelMC@084d78f. This exact solution isn't clean, but it may end up being less data to track).

Player name placeholder confusion

I am using VoteParty to give out VoteKeys when my server reaches 50 votes. Currently, it is not doing that.
command: crate givekey %player_name% voting 1
That is the command I am using and my console gives this message

I don't know what to do here

Implement Cumulative Vote Rewards

Improvement proposal

Hi, I have a suggestion for the plugin ! :)

My team and me had an idea.
Add a Placeholder option that lets you know how many times the VoteParty has been triggered during the day.
Do you think this is a good idea?

Add a "/vp addvote <player> [date]" command

I've seen some people suggest the addition of a command that adds a vote/votes to a player without giving the rewards.

Currently if someone wants to add votes with the rewards they can easily use NuVotifier's /testvote command but it is very hard if not impossible to just add votes to a player without triggering the rewards. I am thinking just user.votes += current.time (or if a date is provided, possibly using SimpleDateFormat then convert it to a timestamp and add that). No vote event calling or anything like that.

This could be pretty useful in some debug and testing situations. Could help test leaderboards without having to need players online, and it could also allow admins to set their vote counter to 69420 to impose their dominance over other players :))

Configuration Issue

Configuration seems to lose track of data after being reloaded. (/vp reload)

exception from placeholder resolution of votes needed.

> [16:00:29 WARN]: me.clip.voteparty.libs.configme.exception.ConfigMeException: No value exists for property with path 'party.votes_needed'. This may happen if the property belongs to a SettingsHolder class which was not passed to the settings manager.
> [16:00:29 WARN]: at me.clip.voteparty.libs.configme.SettingsManagerImpl.getProperty(SettingsManagerImpl.java:57)
> [16:00:29 WARN]: at me.clip.voteparty.placeholders.VotePartyPlaceholders.onRequest(VotePartyPlaceholders.kt:37)
> [16:00:29 WARN]: at me.clip.placeholderapi.PlaceholderAPI.setPlaceholders(PlaceholderAPI.java:375)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.placeholder.PlaceholderAPIHook.replacePlaceholders(Hooks.kt:17)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.APIProvider.setScoreboardValueWithPlaceholders(APIProvider.kt:605)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.TitleManagerPlugin.setScoreboardValueWithPlaceholders(TitleManagerPlugin.kt)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.extensions.PlayerExtensionsKt.setScoreboardValue(PlayerExtensions.kt:169)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.APIProvider$toScoreboardValueAnimation$4.invoke(APIProvider.kt:46)
> [16:00:29 WARN]: at io.puharesource.mc.titlemanager.animations.PartBasedSendableAnimation$update$2.invoke(PartBasedSendableAnimation.kt:11)
> [16:00:29 WARN]: at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [16:00:29 WARN]: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [16:00:29 WARN]: at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> [16:00:29 WARN]: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)

/vote command

Create a /vote command for people to get links to the voting places.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency org.spigotmc:spigot-api to v1.20.4-experimental-snapshot
• chore(deps): update dependency gradle to v8.7
• fix(deps): update dependency ch.jalu:configme to v1.4.1
• fix(deps): update dependency com.github.cryptomorin:xseries to v9.10.0
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/gradle.yml

• actions/checkout v4
• actions/setup-java v4

gradle

settings.gradle

build.gradle

• org.jetbrains.kotlin.jvm 1.9.23
• com.github.johnrengelman.shadow 8.1.1
• com.github.ben-manes.versions 0.51.0
• net.kyori.indra 3.1.3
• net.kyori.indra.publishing 3.1.3
• org.spigotmc:spigot-api 1.20.4-R0.1-SNAPSHOT
• ch.jalu:configme 1.3.0
• me.clip:placeholderapi 2.11.5
• co.aikar:acf-paper 0.5.1-SNAPSHOT
• com.github.cryptomorin:XSeries 9.9.0
• org.bstats:bstats-bukkit 3.0.2
• net.kyori:adventure-platform-bukkit 4.3.2
• net.kyori:adventure-api 4.16.0
• net.kyori:adventure-text-minimessage 4.16.0

version/build.gradle

• org.spigotmc:spigot-api 1.20.4-R0.1-SNAPSHOT

version_new/build.gradle

• org.spigotmc:spigot-api 1.20.4-R0.1-SNAPSHOT

version_old/build.gradle

gradle-wrapper

gradle/wrapper/gradle-wrapper.properties

• gradle 8.6

---

• Check this box to trigger a request for Renovate to run again on this repository

[Feature Request] Folia support

Since NuVotifier (a fork) and many more plugins supports folia I was looking into having this plugin supporting folia if it was possible ?

Feature Request: Design a way to make sure alts can't also get rewards

[feature] Add offline reward for party

Would it be possible, in the future, to add the possibility of receiving party rewards even if you are not online at that moment?

Feature Request: Hook into EssX to block AFK people from getting rewards

Add a way to see the top players from last month

Add a way to see how the leaderboards ended last month. Currently VP automatically updates (or rather every 2 minutes) when the month ends so server owners can't see who ended up being the top voters last month. Since VoteParty already has all this data, it would be nice if it displayed it. All it needs is a bit of processing :).

A lot of people have asked for this feature in the discord channel.

Feature: Per-permission party rewards

Feature already exists in the voting part of the plugin. Add this to the party part also.

FEATURE REQUEST: Adding a time limit to the vote party.

Having a configuration like

days-to-achieve-party: 30
vote-required: 2000

If the server gets 2000 votes in 30 days trigger a vote party, Giving people incentives to vote regularly instead of waiting for regular voters to just reach the total.

VoteParty hook into PlaceholderAPI causing an error.

While having the VoteParty plugin installed, PlaceHolderAPI is sending an error everytime I attempt to reload it with ./papi reload. Here is the full error.

>.... [21:07:09 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'papi' in plugin PlaceholderAPI v2.10.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.15.2.jar:git-Paper-176]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.15.2.jar:git-Paper-176]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.dispatchCommand(CraftServer.java:752) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.PlayerConnection.handleCommand(PlayerConnection.java:1825) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1633) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:1058) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:1051) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:1021) ~[patched_1.15.2.jar:git-Paper-176]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:944) ~[patched_1.15.2.jar:git-Paper-176]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
Caused by: java.lang.NoClassDefFoundError: me/clip/voteparty/VoteParty
at com.gianscode.placeholderexpantion.voteparty.VotePartyExpantion.register(VotePartyExpantion.java:17) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerExpansion(ExpansionManager.java:114) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerAllExpansions(ExpansionManager.java:173) ~[?:?]
at me.clip.placeholderapi.PlaceholderAPIPlugin.reloadConf(PlaceholderAPIPlugin.java:186) ~[?:?]
at me.clip.placeholderapi.commands.PlaceholderAPICommands.onCommand(PlaceholderAPICommands.java:263) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.15.2.jar:git-Paper-176]
... 17 more
Caused by: java.lang.ClassNotFoundException: me.clip.voteparty.VoteParty
at java.net.URLClassLoader.findClass(URLClassLoader.java:382) ~[?:1.8.0_242]
at java.lang.ClassLoader.loadClass(ClassLoader.java:419) ~[?:1.8.0_242]
at java.lang.ClassLoader.loadClass(ClassLoader.java:352) ~[?:1.8.0_242]
at com.gianscode.placeholderexpantion.voteparty.VotePartyExpantion.register(VotePartyExpantion.java:17) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerExpansion(ExpansionManager.java:114) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerAllExpansions(ExpansionManager.java:173) ~[?:?]
at me.clip.placeholderapi.PlaceholderAPIPlugin.reloadConf(PlaceholderAPIPlugin.java:186) ~[?:?]
at me.clip.placeholderapi.commands.PlaceholderAPICommands.onCommand(PlaceholderAPICommands.java:263) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.15.2.jar:git-Paper-176]
... 17 more

Queries for OfflinePlayers from Mojang in Main Thread

Original issue: NuVotifier/NuVotifier#301

Looks like the call to get the offline player from mojang might be a problem.
https://github.com/darbyjack/VoteParty/blob/966d121771f6df0cb68a4221b9ed54a1de48f4e2/src/main/kotlin/me/clip/voteparty/listener/HooksListenerNuVotifier.kt

Better implement the Paper's PlayerProfile API here to avoid sync calls on the main thread.

[Feature Request] More API Events

Implement events for the following:

• Party Start Event
• Party End Event

Players with a full inventory do not receive cumulative rewards

Just as the title says, if a player's inventory is full when they are supposed to receive a cumulative reward. This is due to VotesListener#onReceive returning if the player's inventory is full

VoteParty/src/main/kotlin/me/clip/voteparty/listener/VotesListener.kt

Line 59 in 5522682

return sendMessage(party.manager().getCommandIssuer(online), Messages.VOTES__INVENTORY_FULL)

while the only place the cumulative handlers are called is in this function. Though the cumulative handlers will be called during the next vote, they will not trigger rewards since they require exact values.

Allow crates to be opened by right clicking while holding in hand

Right now you have to place the crate and right click it on the ground to open it. Would be nice to have a configuration option which lets admins toggle it so it only requires the players to right click while holding the crate in hand.