GithubHelp home page GithubHelp logo

darkhax-minecraft / additionalbanners Goto Github PK

View Code? Open in Web Editor NEW
5.0 5.0 13.0 639 KB

A Minecraft mod that adds a plethora of new banner patterns to the game.

License: GNU Lesser General Public License v2.1

Java 100.00%
hacktoberfest

additionalbanners's People

Contributors

3tusk avatar andre601 avatar bardinthedwarf avatar cerus avatar darkhax avatar endilcrafter avatar girafistudios avatar hugoalh avatar illios42 avatar jaredlll08 avatar jriwanek avatar lemmaeof avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

searge-dp immortalcatz tartaricacid deli73 jriwanek-forks bardinthedwarf andre601 exro lemmaeof illios42 endilcrafter pofice

additionalbanners's Issues

[BUG] Some patterns added by this mod seem to be incompatiable with the flags from Supplementaries

Minecraft Version

1.20.1 - Forge version 47.2.0

Mod Version

Additional Banners 14.0.4 - Bookshelf 20.1.9 - Supplementaries 2.8.10 - Moonlight Lib 2.11.9

Mod Loader

Forge

What environment are you running the mod in?

Client

Issue Description

Some (but not all) of the Additional Banners patterns- for example, including the Cobweb and excluding the Anchor- show up as a black and reddish checkerboard when applied to the flags added by the Supplementaries mod. (Please note that Supplementaries is currently still on 1.20.1, so I am using relatively-outdated 1.20.1 versions of Bookshelf and Additional Banners. However, I did not see any indication in the patch notes for later versions of Additional Banners, or on this GitHub bug tracker, that this issue was reported or fixed, so I decided to go ahead and report it anyway.)

I initially encountered this bug on a heavily modded world, but when I attempted to reproduce the issue on a new MultiMC launcher instance, with only the four mods in the "Mod Version" field installed, and no resource packs at all (not even the built-in Programmer Art), the same glitch occurred.

I know basically nothing about coding, so I don't know if Additional Banners or Supplementaries is causing the bug; but I plan to also report this glitch to the Supplementaries issue tracker.

Some screenshots I took of the issue are provided below.

2024-04-02_00 18 44
2024-04-02_00 18 51
2024-04-02_00 18 53

[Request] For the Wandering Trade

Could we potentially get an option to disable the wandering trades? Love everything else but want it to be more compactible with Endremaster which their wandering trader would sell an important item that don't want to be missed or occupied.

hope update 1.17

If you can, I hope to update 1.17. Our server needs it very much

A tale of WTF, and the resultant errors

I had been chasing errors down, since something kept killing my game before it could really start, and I have deduced the cause.

It is the hacky implementation of banners in Lightstones I was given, and it is fucking with your mod. However, the other guy working on the mod seems to be a bit busy with unrelated things, so I'd advise some stuff on your end for now.

Devan-Kerman/ARRP#71

UltrusBot/missing-wilds#1

Flemmli97/AdvancedGolems#2

https://github.com/Paperdomo101/lightstones

Suggestion: Configuration using Crafttweaker

Hey, I'm currently looking for a way to control which item creates which motif.
E.g. I want to use a TConstruct:shovel instead of an iron_shovel to create the shovel motif of the botania mod. (As I want to remove the normal tools from game, and force TConstruct to be used in my modpack)

Since you mentioned something about having a config file, maybe you could provide crafttweaker support instead.
Would you be interested in developing a Crafttweaker plugin that would allow us to:

  • banners.addItems(IItemStack[]) Add banner recipes for items (which have an item representation)(Do not know if this can be done on the fly based on texture of the item or needs textures provided for the new motifs; which would imply some form of resources/textures management)

  • banners.swapItem(IItemStack (old), (IItemstack (new)) (Alter the item used for a specific banner motif (like swap iron shovel with TConstruct Shovel)

  • banners.removeItems(IItemStack[]) Remove banner recipes for certain items (so that we e.g. could provide those as quest rewards, but cannot be made!) (Based on input or maybe a name)

  • Provide integration with the mod JustEnoughPatternBanners https://github.com/Lorexe/JustEnoughPatternBanners so that updates made by crafttweaker properly reflect in JEI?

  • banners.motifs() as IItemStack[] A way to obtain a list of all banner motifs (aka input items)

  • banners.removeAll() A quick and easy option to remove all possible banner designs

I think more functionality based on patterns, or banner stages, ... could be requested by others, but I think this would be a great base to start with.

Guinaro

Asking for Repost Permission

Hi, my name is PinWheel, I really like your mod. I wonder if I can repost this mod on MCBBS which is the largest Chinese Minecraft forum. Due to the barrier of language, most Chinese players are not able to play or even find this great mod. Thus I would like to introduce this mod to more Chinese players so that they can enjoy your mod as well. The entire repost will obey the rules list below and your own special requests.

  • I will NOT take any credits of the mod and I will clearly state your official website (Curseforge and Github) at the head of my repost page.

  • I will give the official download link directly and clearly note that "This is the official download link, please click here first"

  • (Optional) In a case of the network firewalls (government policy stuff...) and network speed, I probably prepare another mirror link for backup. The mirror will direct to an Ad-free page (very like Dropbox).

  • Last but not least, I will not use this mod to get profit/benefit in terms of money, etc... And I will clearly state that anyone who uses this mod must not use it to make money.

I will be really appreciated if you can give me permission.
Anyway, thank you for bringing us such an amazing mod and so much fun.

Yours sincerely,
PinWheel

Crarting Impossible

Minecraft version: 1.13.2
Forge version: forge-1.13.2-25.0.99

I cannot create any banner. Are the tutorials on youtube all outdated? I tried AdditionalBanners-1.13.2-3.0.4.jar and AdditionalBanners-1.13.2-3.0.3.jar, but none of these worked. There is no crash, and I'm pretty sure It's loaded by forge in the startmenu forgelist.

If there is any infomation I needed to provide, please let me know.

[Bug] Shield Recipe not working

Crafting the shield recipe using the door doesnt work, and while looking in your code i realized the id you used for the door "oak_door". However the id for the oak door is "wooden_door", even though the ids for the other doors are using the wood type. Moreover i would like to suggest the addition of all door types to the recipe. that way, you do not need specifically oak to make it.

Thank you very much and i hope to see more banners coming.

By the way, i would also like to offer my time to help you enhance this mod, by making each texture myself, as im experienced with the art of texture making, and graphic designing. I have already taken the time to make some more developed textures unlike the standard simple items. If you are interested in contacting me please do so through this github message.

Keep up with the good work, and im looking foward to hearing from you

Tag Doesn't Exist: Hexagon Banner

Client Information

MC version: 1.19.2
Mod Version: 1.19.2-10.1.6
Forge Version: 43.2.8

Bug Information

Cannot craft the hexagon pattern. This is the only mod besides JEI that I have enabled.

image

Console spam when JEI is loaded.

Version 1.5.38

[12:16:20] [main/INFO]: Registering plugin: net.darkhax.additionalbanners.jei.AdditionalBannersJEI ...
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: base
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: square_bottom_left
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: square_bottom_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: square_top_left
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: square_top_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_bottom
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_top
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_left
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_center
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_middle
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_downright
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: stripe_downleft
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: small_stripes
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: cross
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: straight_cross
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: triangle_bottom
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: triangle_top
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: triangles_bottom
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: triangles_top
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: diagonal_left
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: diagonal_up_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: diagonal_up_left
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: diagonal_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: circle
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: rhombus
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: half_vertical
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: half_horizontal
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: half_vertical_right
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: half_horizontal_bottom
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: border
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: curly_border
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: creeper
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: gradient
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: gradient_up
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: bricks
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: skull
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: flower
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: mojang
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_bread
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_fish
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_fishn
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_shield
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_pot
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_bed
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_book
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_bow
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_bucket
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_write
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_wheat
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_paper
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_shear
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_apple
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_egg
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_sword
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_axe
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_hoe
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_pick
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_shovel
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_boots
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_legs
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_chest
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_helm
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_horse
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_pumpkin
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_grass
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_pillar
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_cobble
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_tag
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_dragon
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_squid
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_planks
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_balance
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_hashtag
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: additionalbanners_cap
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: actuallyadditionsdrill
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: actuallyadditionsleaf_blo
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: actuallyadditionsphan_con
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: actuallyadditionsbook
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: quark_dragon
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: quark_eye
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: quark_shield
[12:16:20] [main/INFO]: [net.darkhax.additionalbanners.jei.RecipeWrapperBanners:<init>:14]: Added banner pattern: quark_sword

Request - New Banner(s)

A spider web design for banners (This one's texture can easily be made using the cobweb's item texture stretched over the basic Banner shape) - Pattern created using cobweb and paper

A Spider Design for on banners (This one doesn't have to be too complicated, it can be as simple as a circle with 8 L shaped legs. It worked for Spiderman's classic design, so it should work for Minecraft just as easily! xD) - Pattern created using a spider eye and paper

Banners acting... weird? (shaders vs. no shaders)

I tried using a /give code to give myself a banner and got this issue. I tried crafting it manually and had the same problem. Banners look fine without shaders, but with shaders are super glitchy, change as you look at them, and have different patterns on the front and back. It doesn't matter how many layers are on the banner, or which shader pack is in use. I'm running a few mods related to banners (Additional Banners, More Banner Features, and More Banner Layers), so I tried turning those off one by one, but that still didn't fix it.

Knowing Minecraft modding it's probably Geckolib or Iris fucking up the whole routine as usual but if there's a fix (or if it might be something else) please let me know! (I can send you a list of all the mods I'm using, but it's a LOT, and most of them wouldn't affect banners at all)

UPDATE: Just tried downgrading Iris, and it fixed the problem. I'm going to link this report to their page as well, but if there's any fix you can think of please share. Thanks

2023-04-11_14 08 14
2023-04-11_14 09 48
2023-04-11_14 08 30
2023-04-11_14 09 46

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.