darkhax-minecraft / dark-paintings Goto Github PK

Issue description:
The server will not start.

Server error log:
https://www.toptal.com/developers/hastebin/ayerizineh.sql

Work-around:
Remove Dark Paintings from mods folder...

Versions:
DarkPaintings-Fabric-1.19-11.0.2.jar
Minecraft 1.19
Fabric Loader 0.14.8
Fabric API 0.57.0
Iris 2.0.4

Sorry, what am I doing wrong here?
Thank you in advance.

Under what license are the assets of this mod published? The Curseforge and Modrinth page mention LGPL, but this is not reflected in the Github source.

I'm asking because I've been wanting to create a compatibility pack for my mod (https://github.com/enjarai/client-paintings) containing the paintings of this one. Would this be possible, or would you prefer I didn't either way?

The mod requires Bookshelf to work, but it isn't specified in fabric.mod.json, causing crash without Fabric telling the user that there's another mod he needs to install. And it isn't mentioned explicitly on the Curseforge mod page too, the user has to either be aware of Relations tab on Curseforge and think about checking it, or someone else has to tell about it. This severely increases the amount of users not understanding why the mod doesn't work, which could impact the mod's popularity.

[16:37:55] [Forge Version Check/INFO]: [darkpaintings] Starting version check at https://updates.blamejared.com/get?n=darkpaintings&gv=1.19.2
[16:37:55] [Forge Version Check/WARN]: Failed to process update information
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
	at com.google.gson.Gson.fromJson(Gson.java:975) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:928) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:877) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:848) ~[gson-2.8.9.jar%23121!/:?]
	at net.minecraftforge.fml.VersionChecker$1.process(VersionChecker.java:183) ~[fmlcore-1.19.2-43.2.0.jar%231226!/:?]
	at java.lang.Iterable.forEach(Iterable.java:75) [?:?]
	at net.minecraftforge.fml.VersionChecker$1.run(VersionChecker.java:114) [fmlcore-1.19.2-43.2.0.jar%231226!/:?]
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
	at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:384) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:183) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145) ~[gson-2.8.9.jar%23121!/:?]
	at com.google.gson.Gson.fromJson(Gson.java:963) ~[gson-2.8.9.jar%23121!/:?]
	... 6 more

Nothing crash worthy, just an unneeded stacktrace in the logs.

Visiting the site manually says this: Invalid projectName "darkpaintings" and gameVersion "1.19.2"!

Please, change the name of the painting for Enderman. When include this mod together with the Builders Addition mod, no paintings from Builders Additions are included, with the server-side crashes like following:

Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.IllegalArgumentException: Multiple entries with same value: Reference{ResourceKey[minecraft:painting_variant / buildersaddition:enderman]=net.minecraft.world.entity.decoration.PaintingVariant@1bc9f1c3}=DARKPAINTINGS_ENDERMAN and Reference{ResourceKey[minecraft:painting_variant / darkpaintings:enderman]=net.minecraft.world.entity.decoration.PaintingVariant@50a89074}=DARKPAINTINGS_ENDERMAN [in thread "Server thread"]
at com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:376) ~[guava-31.0.1-jre.jar%23105!/:?]

OR, is there a way to change it or remove it using the data pack? If yes, please, provide an example for the workaround.

(Submitting this to both Builders Addition and Dark Painting mods issues - mrh0/buildersaddition#76)

Might want to check this out for your Resource Pack

It seems old-fashioned but from what I remember Paintings++ packs have to be more than a resource pack,

example from the default .json:
"paintings": [ { "name": "abstract_blue", "square": 16 }, { "name": "abstract_rainbow", "square": 16 }, { "name": "abstract_red", "square": 16 },

crashes on start in 1.19.3 fabric
The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'darkpaintings'!

Should redirect here.