dart-league / validators Goto Github PK

Hi, can you bring in my library? I have an IMEI validator.
https://github.com/ThinkDigitalRepair/imei_validator

I would like to propose that this package should remove its dependency on vin_decoder.
My reasoning is:

• it looks like it is only used for this simple function:

/// check if the string is a valid ISO 3779-compliant Vehicle identification
/// number (VIN)
bool isVIN(String str) {
  VIN vin = VIN(number: str);
  return vin.valid();
}

which could be easily pasted by the users who need it

• validators is used by many other packages
• vin_decoder has many dependencies, e.g. to http , basic_utils and random_string which are also used by many other packages
• therefore, it is likely to run into dependency conflicts because of all these transitive dependencies
• I think the VIN feature is only used by a tiny fraction of users, but many are currently having issues with dependencies due to the migration to null safety

This would be a breaking change, but IMO it would be worthwhile. validators would then be a package without any dependencies.

If I try to valid a master card credit card number starting with 230744 from C6 Bank (Brazil) the function isCreditCard return false.

isURL('https://test_url.com/', allowUnderscore: true)
this returns false

Given the following website:

website = http://www.example

When I call isURL on it with the following options, I get true, when I expected to get false as this is not a valid URL. I understand the requireTld option defaults to true.

isURL(website, requireProtocol: true, allowUnderscore: true)

I am using version ^2.0.0+1

Feature Request for some more validators:

• isCIDR: check if value is a valid CIDR notation
• isLocale: check if value is a valid locale string
• isTimezone: check if value is a valid timezone string

I want to validate the Brazilian date format, is it possible?

isUrl() method returns false if url сyrillic symbols
For example: http://президент.рф

Because it does not only check if str == null but also checks if str.length == 0
(you could also refactor and use a built-in str.isEmpty instead of direct length accessing)

isFloat() recognizes this length of integer "66666666666" as a float .

The behaviour of hostWhitelist and hostBlacklist seems to be inverted.

My understanding is that if I add www.example.com as a whitelisted host, the method isURL should only return true if the host of the url being tested matches at least one of the values in the whitelist.

e.g.

If I have hostWhitelist = ['www.example.com'], and I test the string www.example.com, I'd expect the method to return true. And if I test the string www.another.com, I'd expect the method to return false.

In a similar manner, if I have hostBlacklist = ['www.example.com'], and I test the string www.example.com, I'd expect the method to return false. And if I test the string www.another.com, I'd expect the method to return true.

However, the code seems to be inverted.

if (hostWhitelist.isNotEmpty && hostWhitelist.contains(host)) {
  return false;
}

if (hostBlacklist.isNotEmpty && !hostBlacklist.contains(host)) {
  return false;
}

From https://github.com/dart-league/validators/blob/master/lib/validators.dart#L183-L189

I use the isNull() (https://pub.dev/documentation/validators/latest/validators/isNull.html) function quite often but I find its name misleading. Could you create an isNullOrEmpty() alias function (so that it doesn't break backward compatibility for people using this function) so that calls to this function would be self explanatory and wouldn't mislead anyone reading the code.
Thanks

ref. https://gist.github.com/yongjhih/1508e47e853bfb6b2d6ae2dd6f76d8c5

The email with ellipsis (...) after the @ is not valid, but it accepts.

Example: [email protected]

Title pretty much explains the issue.

Can't upgrade json_annotation/json_serializable package...

Because no versions of validators match >2.0.1 <3.0.0 and validators 2.0.1 depends on vin_decoder ^0.1.2, validators ^2.0.1 requires vin_decoder ^0.1.2.

And because no versions of vin_decoder match >0.1.2 <0.2.0, validators ^2.0.1 requires vin_decoder 0.1.2.

And because vin_decoder 0.1.2 depends on basic_utils ^2.5.4 which depends on json_annotation >=2.0.0 <=3.0.1, validators ^2.0.1 requires json_annotation >=2.0.0 <=3.0.1.

So, because nudged depends on both json_annotation ^3.1.0 and validators ^2.0.1, version solving failed.

When I try to get packages, I get this error;
`The current Dart SDK version is 2.1.0-dev.9.4.flutter-f9ebf21297.

Because ***** depends on validator any which requires SDK version <2.0.0, version solving failed.

pub get failed (1)`

isUrl does not correctly validate IPv6 Urls. When using IPv6 brackets are allowed within the hostname, ie, http://[2001:db8::1]/.

Are there plans to add null safety support to this package? If so can you estimate when? Thanks very much for your work.

This function has a return type of 'String', but doesn't end with a return statement.

All FormFieldValidators should return null if no validation error occurs.

Passes validation with require_protocol option set true.

if (!validator.isURL('www.example.com',{'require_protocol':true} )){
  return 'Enter a valid URL (e.g. http://example.com)';
}

isUrl() method returns false if url contains umlauts: ä,ü,ö.
For example: http://süddeutsche.de