GithubHelp home page GithubHelp logo

Wiggle plot Index Error about dascore HOT 3 CLOSED

d-chambers avatar d-chambers commented on June 16, 2024
Wiggle plot Index Error

from dascore.

Comments (3)

d-chambers avatar d-chambers commented on June 16, 2024

Hey @ahmadtourei,

If you have time, want to work on this one? The wiggle plots need a bit of refactoring. A few things to do:

1. Fix this issue

Write a test for the issue above and ensure a matplotlib axis is returned rather than raising an error.

2. Make sure wiggles work in the docs

The wiggle plots aren't working in the documentation. For example, on the processing page of the tutorial we see this:

image

Figure out why and fix the issue

3. Efficiency

Test (just locally, don't include a test for this because it will slow down the test suite) a larger patch, maybe just the random patch, or some real data, see if it is fast enough to plot. We may need to stop coloring in the negative parts of the wiggles to make plotting more efficient.

4. Test coverage

When I run

pytest --cov dascore --cov-report term-missing

I see this:
image

Notice how there are 10 of the 60 lines of code that aren't run? You see these in the last column, lines 62-66, 72-75, and 98. See if you can write some tests to execute those lines of code (or just make sure the re-factored version has higher coverage, 100% if possible).

from dascore.

ahmadtourei avatar ahmadtourei commented on June 16, 2024

Thanks for the explanation, @d-chambers! I may start working on it in the last week of August.

from dascore.

d-chambers avatar d-chambers commented on June 16, 2024

closed by #269

from dascore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.