Comments (3)
Hey @ahmadtourei,
If you have time, want to work on this one? The wiggle plots need a bit of refactoring. A few things to do:
1. Fix this issue
Write a test for the issue above and ensure a matplotlib axis is returned rather than raising an error.
2. Make sure wiggles work in the docs
The wiggle plots aren't working in the documentation. For example, on the processing page of the tutorial we see this:
Figure out why and fix the issue
3. Efficiency
Test (just locally, don't include a test for this because it will slow down the test suite) a larger patch, maybe just the random patch, or some real data, see if it is fast enough to plot. We may need to stop coloring in the negative parts of the wiggles to make plotting more efficient.
4. Test coverage
When I run
pytest --cov dascore --cov-report term-missing
Notice how there are 10 of the 60 lines of code that aren't run? You see these in the last column, lines 62-66, 72-75, and 98. See if you can write some tests to execute those lines of code (or just make sure the re-factored version has higher coverage, 100% if possible).
from dascore.
Thanks for the explanation, @d-chambers! I may start working on it in the last week of August.
from dascore.
closed by #269
from dascore.
Related Issues (20)
- Waterfall plot with timedelta coordinate fails
- coord error for stop>start and negative step
- Python 3.12 conda installation error HOT 3
- Scan not robust to corrupted file
- Cant remove units with set_units(None)
- Converting example event to obspy fails
- Conda installation issues HOT 8
- Indexing a folder with a subfolder that a user does not have permission to access
- `to_float` time util doesnt work with `Series`
- Better control of merging from spool.chunk HOT 1
- spool.select doesn't support relative argument
- Attrs.update(coord=...) doesnt update dims
- Cross references in note section broken
- timedelta's should work with units HOT 2
- Enforce int dtypes in select when samples is True HOT 1
- spool with zero patches for binary data HOT 3
- spool.chunk raises a KeyError although all required columns are presented in the spool dataframe HOT 5
- patch.dft() does not change data_type HOT 2
- dft should be idempotent
- velocity_to_strain_rate function issues
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dascore.