dasgeekchannel / autoinstallbashscripts Goto Github PK

$ sudo ./installscript
install: invalid option -- 'y'
Try 'install --help' for more information.
./installscript: line 13: update: command not found
Reading package lists... Done
Building dependency tree
Reading state information... Done
Entering ResolveByKeep 10%
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
./installscript: line 328: syntax error near unexpected token do' ./installscript: line 328: do'

You call currentuser=$(who | awk 'NR==1{print $1}') multiple times throughout the script, even within the same function (EX: Lines 253, 259, and 261 after calling it originally in Line 239). The currentuser variable is going to stay until the script ends or if the user magically changes mid-way through the script (highly unlikely).

Not to mention, $USER is built in and sticks through sudo: (try echo $USER and sudo echo $USER in a terminal window) so as far as I can tell this is unnecessary in the first place...

Is there any specific reason you're doing it this way?

Are the drivers not from the 'Padoka' series rather than Proton that you mention in the script?

this is the UNSTABLE, built from git padoka ppa

./installscript: line 509: unexpected EOF while looking for matching ``'
./installscript: line 638: syntax error: unexpected end of file

Hi,

When I try and install Vivaldi with the script I get:

dpkg: error: cannot access archive 'vivaldi-stable_1.14.1077.55-1_amd64.deb': No such file or directory

PS - Thanks for Destination Linux. I love it!

jack does not install on Ubuntu 18.04 unless you apt update && apt upgrade packages first. Then re-login.

$ sudo apt update && sudo apt upgrade -y
$ sudo apt install jackd2 carla-git non-mixer pulseaudio-module-jack cadence

There are a few inconsistencies in this script:

1. Both apt and apt-get are used
2. Despite needing to run the script with escalated privileges sudo is ran for many packages
3. All SNAP programs install snapd before installing the snap package, despite snapd being its own install near the top of the script.

Here is what I advise:

1. Standardize on apt or apt-get
2. Either remove the need for escalated privileges at the start of the script or remove the odd sudo commands
3. Make the SNAP packages rely on having the script's snapd installed (if possible).