datagovsg / beeline-eta Goto Github PK

main.js

1. Use the python scheduler -- https://docs.python.org/2/library/sched.html
2. I'm not sure if threading will work the way you expect. See note at https://docs.python.org/2/library/threading.html#thread-objects ("Only one thread can execute Python code at once"). Try using multiprocessing.Pool instead

utility.py
3. Use numpy.percentile
4. contains_all_values is a misnomer. A contains B is not equivalent to set(A) == set(B)

trip_helper.py
5. get_trip_tripstops() Don't use the bitwise-and (&) operator when you actually mean the logical and (and) operator (https://docs.python.org/2/library/operator.html#mapping-operators-to-functions)
6. get_timings -- get_intervals ?
7.

I'll be adding more comments