datavisyn / github-workflows Goto Github PK

The deploy-product.yml requires the DV_DEVOPS secret, and receives it via secrets: inherit from the jobs in the product. But this fails, as it's not there. There is no corresponding variables setting, therefore we will just use the org vars directly.

• use deployment workflow of infrastructurek8s
• add qa process
• use images of ga
• remove circleci

For Sightline we have to add a tag containing the github sha to the image that is pushed to the AWS ECR (in addition to develop etc.). Please add a flag for this that allows to add an additional tag with the github sha to the image (general flag, independent of application).

Our default timeouts (6h) are too long for most jobs. See https://github.com/datavisyn/patentbay_product/actions/runs/5733724589, where it waited for 3h+.

This is quite costly, and we should change that to a reasonable number.

• in build-* files: check if publish == true, if the project is private and if yes, throw an exception

Preferred: https://github.com/marketplace/actions/slack-send
Read: https://javascript.plainenglish.io/be-aware-of-your-github-actions-workflow-with-slack-35d1f46821cf

We have to discuss which messages are interesting for the team

Based on the new Deployment and QA Process definition, we need a workflow/GA that automatically moves the tickets to the correct columns in the respective boards. This is most important for QA tickets, that are planned within a sprint, created within the application Github project (e.g. sightline) and added to the testing Github project as well:

• Note that these tickets have the label type: qa
• While the QA team is testing, they manually move the ticket to "In Progress" in the testing Github project --> the ticket should then be transferred automatically to "In Progress" in the application Github project as well
• Once the QA team is done, they will move the ticket manually to "Done" in the testing Github project --> the ticket should then be transferred automatically to "Review" in the application Github project
• The PO takes the ticket from "Review", derives his/her measures, and moves the ticket to "Closed" in the application Github project --> the ticket should then be transferred automatically to "Closed" in the testing Github project as well

If any of this is unclear, please feel free to ping me!

https://github.com/projectatomic/dockerfile_lint

Milestones for issues in Github can be created manually and are very useful for communicating and setting deadlines/timelines for issues. Creating them manually in multiple repositories is a tedious task. Please investigate whether it is possible to create them automatically (e.g. one milestone per week, the due date is always the Friday in that particular week and the name includes the due date in the format Milestone-<month>/<day>/<year>)

we don't need to create the workspace for single apps

special repos:

• tdp_marvinjs
• tdp_infochem
• reprovisyn
• datavisyn_landing_page

for the first two we should make the image in the repository. For reprovisyn we have to think if we should build it during the product build

Summary

In the prepare-build job, the lint dockerfiles step fails without showing the actual error even though corresponding logs were added to the hadolint script. Despite facing an actual lint error in the Dockerfile, the show dockerfile lint error step is just omitted. This can be seen in the screenshot below:

Expected Behavior

We would expect to see more logs in the lint step and especially the show dockerfile lint error should never be omitted if errors occur.

Corresponding Github Action: https://github.com/datavisyn/github-workflows/tree/new_deployment/.github/actions/lint-docker

fe https://github.com/datavisyn/aelixir_product/actions/runs/3486803730