datenanfragen / company-json-generator Goto Github PK

I only pressed Enter once to trigger the helper and then once again to confirm the alert. Still, the helper is triggered again:

We should support loading an existing record into the generator from a file.

Since this feature is especially useful for validating and fixing community contributions, we should also support loading records from the URL (as a base64-encoded string or similar).

The tool can already load records from a number of sources, including from the data repository (through the slug parameter) and from JSON (through the doc parameter):

We should add the ability to load a record from an arbitrary URL through a new url parameter. As the implementation will be very similar to the one for the slug parameter, we should reuse that code.

The idea behind this is that we wouldn't need to encode the whole record in the URL in our backend anymore for suggest PR "Edit" links. Instead, we could just reference the raw file on GitHub (like: https://raw.githubusercontent.com/datenanfragen-community-edits/data/suggest_haspa_1631904031723/companies/haspa.json) and load that.
The added bonus of that is that this would allow the "Edit" link to continue working even after changes have already been made to the PR.

Seems like the JSON generator now fetches the file from a PR (#31), but doesn't seem to be working?

Eg: datenanfragen/data#1563

-> https://github.com/datenanfragen/company-json-generator/blame/master/README.md#L10

The source code for this tool uses an awful mix of old and new JS and has gotten quite messy over time.

We should refactor and clean up the source code and convert it to TypeScript, making use of modern JS and TS features.

As the code for the tool is quite short and not complex, this issue is well suited for people new to our project. But you need to be familiar with modern JS and TS already.

issue description

• When using the slug helper to generate a slug based on the URL, the generated slug is added to the slug textbox. However, when the JSON record is generated, it doesn't contain a slug.
  A similar thing happens with the email helper.
• When using the phone/fax number formatter to reformat the phone/fax number, the new formatted number appears correctly in the textbox. But when generating the JSON record, it still contains the old format of the number.

-> While the website changes the values, the changes aren't considered when generating the JSON record.

expected result

The generator uses the displayed, formatted text to generate the JSON record.

steps to reproduce

1. Add https://example.com as the website
2. Press enter and confirm the dialog to generate the slug
3. check that the slug textbox now contains example-com
4. press the "Generate" button
   -> The JSON record view doesn't contain the slug.

Alternatively:

1. Add 004987654321 as the phone/fax number
2. press enter, add the ISO 3166-1 alpha-2 country code de, and confirm the dialog
3. check the phone/fax number textbox. it should have changed to +49 8765 4321
4. press the "Generate" button
   -> The JSON record has 004987654321 instead of +49 8765 4321 as the phone/fax number.

The JSON schema for datenanfragen/data, requires a name attribute, but the generator only has desc attribute

"required-elements": [
        {
            "desc": "example",
            "type": "input",
            "optional": true
        }
    ],

E.g. click on the "Edit" link in datenanfragen/data#946
It contains some "optional": falses. But they are not picked up by the cjg:

Seems to be a bug in brutusin-json-forms and not in our code.. But still quite annoying.