davevs / pyscs Goto Github PK

For some reason no controls are selected. I suspect this is because BagOfFindings is not filled due to the selection in line 203 always producing a False.

Probably this is due to some conversion error in the csv import module.

example:

https://groups.google.com/d/msg/blockdiag-discuss/ZVG1vEX91d0/SHh_1SmFmwcJ

currently boundaries are a subclasss of element. This is ugly and introduces a lot of unnecessary checks.

it's not implemented in the pyTM Dataflow class even though there's a variable declared.
seqdiag does support it.

python3 pySCS.py models/sample/

Processing: models/sample/model.py
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pydot.py", line 1915, in create
working_dir=tmp_dir,
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pydot.py", line 136, in call_graphviz
**kwargs
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 709, in init
restore_signals, start_new_session)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 1344, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'dot': 'dot'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "pySCS.py", line 592, in
exec(open(model_file).read())
File "", line 57, in
File "pySCS.py", line 269, in process
self.dfd()
File "pySCS.py", line 283, in dfd
output_dfd()
File "pySCS.py", line 239, in output_dfd
dfd_in_progress.write_png(dfd_file)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pydot.py", line 1734, in new_method
encoding=encoding)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pydot.py", line 1817, in write
s = self.create(prog, format, encoding=encoding)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pydot.py", line 1922, in create
raise OSError(*args)
FileNotFoundError: [Errno 2] "dot" not found in path.

Find a safer alternative to load the model.

exec(open(model_file).read())

• remove unused code
• cleanup comments
• cleanup debug statements

Change the flow to create the dfd, sequential diagram, and report in 1 single flow.
Now you need to run the tool 3 times to get all three of them.

partially implemented in pytm, but no longer working