davewasmer / broccoli-favicon Goto Github PK

Hello!
I've forked this repo to see what is going on with davewasmer/ember-cli-favicon#2 but Tests fails on my localhost with node 0.12.7. Which version are you running?

I have an issue between my ci based on alpine docker image and node-gyp and sharp

https://gitlab.com/c1560/cryptofiscafacile/-/jobs/6017169118 this one for example.

I saw sharp@npm:0.28.3 is pull by

❯ yarn why sharp
├─ cryptofiscafacile-gui@workspace:frontend
└─ favicons@npm:6.2.2
└─ sharp@npm:0.28.3 (via npm:^0.28.2)
❯ yarn why favicons
└─ broccoli-favicon@npm:3.0.0
└─ favicons@npm:6.2.2 (via npm:^6.2.2)

I am opening this issue to hopefully save others from spending time trying to get this plugin to work. The plugin and its dependent ember-cli-favicon have not been updated to work with the latest versions of favicons, ember-cli, or the current broccoli plugin specification. Among other problems, this causes all possible icons to be generated regardless of any attempts at setting the favicons configuration. Just create and reference favicons manually until this plugin is next updated.

When the Favicons will publish a new release we should upgrade it ASAP to fix: itgalaxy/favicons#234

Current version of favicon is 6.0, but as of v5.4 favicon no longer depends on phantomjs. Given phantomjs has been deprecated for 2+ years, it would be nice to not be pulling it as a dep anymore. Is there any particular reason the favicon dep is locked to ~5.3.0, rather than ^5.3.0?

Running npm audit in an Ember-CLI app with [email protected] (which depends on broccoli-favicon@^3.0.0) currently yields the following warning, indicating a downgrade would be necessary to clear it:

sharp  <0.30.5
Severity: moderate
sharp vulnerable to Command Injection in post-installation over build environment - https://github.com/advisories/GHSA-gp95-ppv5-3jc5
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/sharp

The sharp issue has been cleared in [email protected] so hopefully these packages can do the same shortly.

Hi, first of all, thanks for this plugin and ember-cli-favicon.

I was noticing some 404s when using ember-cli-favicon and it seems that this is due to this package not saving the json output of favicons, while it is included in the HTML. Would it be possible to also pipe these through? Or am I expected to generate my own manifest?