david-mark / my-library Goto Github PK

Not using strict is contrary to best practice advice by Douglas Crockford and other people that seem to know JavaScript well.

🎃

There are no instructions on how to turn mylib.asp into a javascript file.

This may be a good time to add a README.

recommended README.md format

Note the API documentation should just link to the website.

Also note that github projects without readmes are considered "unfriendly". At least I personally find them so.

Further note: Using asp as a build system is "ugly" and not very cross-platform system. It's "popular" these days to use node.js as a build system. Note that using node.js (or any other build system) would allow you to split the main mylib file into multiple files (similarly to how jQuery does so). As for being cross platform one can use makefiles to run a node build file in *unix environments and use windows .cmd files to run build scripts in a windows environment.

And if they don't exist they should probably be written. As reputable as you are, everyone makes mistakes.

If wanted I can write the first couple of unit tests with a reputable unit testing library and set up a test page.

elements with class such as 'no-feature' will report true for hasClass('feature');