Fails to run on mac about pyflow

[David-OConnor]

This is likely due to incorrect assumptions I made about the directory structure on Mac.

Could you please:

• Post the directory structure Pyflow built inside __pypackages__ ?
• If able, add the line println!("Lib path: {:?}", lib_path); at the top of the download_and_install_package function in src/install , rebuild and rerun, and report what it outputs?

I'm suspicious there are other issues related to directories on Mac that you'll run across once this is sorted. I'd love to get this working/tested/binaries released on Mac.

[alok]

Directory structure:

.
└── 3.7
    ├── .venv
    │   ├── bin
    │   ├── include
    │   └── lib
    │       └── python3.7
    │           └── site-packages
    │               ├── __pycache__
    │               ├── pip
    │               │   ├── __pycache__
    │               │   ├── _internal
    │               │   │   ├── __pycache__
    │               │   │   ├── cli
    │               │   │   │   └── __pycache__
    │               │   │   ├── commands
    │               │   │   │   └── __pycache__
    │               │   │   ├── models
    │               │   │   │   └── __pycache__
    │               │   │   ├── operations
    │               │   │   │   └── __pycache__
    │               │   │   ├── req
    │               │   │   │   └── __pycache__
    │               │   │   ├── utils
    │               │   │   │   └── __pycache__
    │               │   │   └── vcs
    │               │   │       └── __pycache__
    │               │   └── _vendor
    │               │       ├── __pycache__
    │               │       ├── cachecontrol
    │               │       │   ├── __pycache__
    │               │       │   └── caches
    │               │       │       └── __pycache__
    │               │       ├── certifi
    │               │       │   └── __pycache__
    │               │       ├── chardet
    │               │       │   ├── __pycache__
    │               │       │   └── cli
    │               │       │       └── __pycache__
    │               │       ├── colorama
    │               │       │   └── __pycache__
    │               │       ├── distlib
    │               │       │   ├── __pycache__
    │               │       │   └── _backport
    │               │       │       └── __pycache__
    │               │       ├── html5lib
    │               │       │   ├── __pycache__
    │               │       │   ├── _trie
    │               │       │   │   └── __pycache__
    │               │       │   ├── filters
    │               │       │   │   └── __pycache__
    │               │       │   ├── treeadapters
    │               │       │   │   └── __pycache__
    │               │       │   ├── treebuilders
    │               │       │   │   └── __pycache__
    │               │       │   └── treewalkers
    │               │       │       └── __pycache__
    │               │       ├── idna
    │               │       │   └── __pycache__
    │               │       ├── lockfile
    │               │       │   └── __pycache__
    │               │       ├── msgpack
    │               │       │   └── __pycache__
    │               │       ├── packaging
    │               │       │   └── __pycache__
    │               │       ├── pep517
    │               │       │   └── __pycache__
    │               │       ├── pkg_resources
    │               │       │   └── __pycache__
    │               │       ├── progress
    │               │       │   └── __pycache__
    │               │       ├── pytoml
    │               │       │   └── __pycache__
    │               │       ├── requests
    │               │       │   └── __pycache__
    │               │       ├── urllib3
    │               │       │   ├── __pycache__
    │               │       │   ├── contrib
    │               │       │   │   ├── __pycache__
    │               │       │   │   └── _securetransport
    │               │       │   │       └── __pycache__
    │               │       │   ├── packages
    │               │       │   │   ├── __pycache__
    │               │       │   │   ├── backports
    │               │       │   │   │   └── __pycache__
    │               │       │   │   └── ssl_match_hostname
    │               │       │   │       └── __pycache__
    │               │       │   └── util
    │               │       │       └── __pycache__
    │               │       └── webencodings
    │               │           └── __pycache__
    │               ├── pip-19.0.3.dist-info
    │               ├── pkg_resources
    │               │   ├── __pycache__
    │               │   ├── _vendor
    │               │   │   ├── __pycache__
    │               │   │   └── packaging
    │               │   │       └── __pycache__
    │               │   └── extern
    │               │       └── __pycache__
    │               ├── setuptools
    │               │   ├── __pycache__
    │               │   ├── _vendor
    │               │   │   ├── __pycache__
    │               │   │   └── packaging
    │               │   │       └── __pycache__
    │               │   ├── command
    │               │   │   └── __pycache__
    │               │   └── extern
    │               │       └── __pycache__
    │               └── setuptools-40.8.0.dist-info
    └── lib

111 directories

lib_path: $PROJECT_ROOT/__pypackages__/3.7/.venv/lib64/python3.7/site-packages

[David-OConnor]

Could you please add the line: println!("pypackges dir: {:?}", &pypackages_dir); at line 1333 of src/main.rs, (Right after it's assigned) and post the result? I'm not sure why the __ is being ommitted. It also looks like there's an issue regarding lib vs lib64. Note that this is being triggered when attempting to install wheel, when building the env.

I appologize for asking you to run through these, but I'm not sure how to test on Mac.

edit: Disregard this post.

[David-OConnor]

Nvm: The problem is lib vs lib64; I misinterpreted GH's formatting __ as bold.

Would you please modify line 470 of src/py_versions.rs, to replace lib64 with lib, and try again ? Ie:

    PathBuf::from("lib").join(&format!("python{}.{}", py_ver.major, py_ver.minor));

[alok]

Did that. Now I don't get that error and it creates a lockfile, but the lockfile is empty and no packages are actually downloaded (numpy in this case).

[alok]

Here's the lockfile:

package = []

[metadata]

[David-OConnor]

Could you please post the contents of [tool.pyflow.dependencies] in pyproject.toml ?

[alok]

# See PEP 518: https://www.python.org/dev/peps/pep-0518/ for info on this file's structure.

[tool.pyflow]
name = ""
py_version = "3.7"
version = "0.1.0"
author = ""


[tool.pyflow.scripts]


[tool.pyflow.dependencies]
numpy = "^1.17.2"


[tool.pyflow.dev-dependencies]

[David-OConnor]

Thank you. Could you run pyflow reset, and try again?

[alok]

Same issue.

[David-OConnor]

This may be related to a broken commit I pushed last night:

Can you please remove this chunk of code in src/main.rs, at line 1141, and try again?

combined_reqs = combined_reqs
        .into_iter()
        .filter(|r| r.git.is_some())
        .collect();

At this point, probably not a Mac issue; I'll be able to push a new commit this evening.

[alok]

Looks like that's it. I was able to install after deleting that.

[David-OConnor]

Fixed in latest commit.

[David-OConnor]

Released