davidbinneun / hitlist

hello 👋

Coding for fun from a young age, I majored in CS in high school and participated in the Cyber4s program for discharged combat soldiers. I'm a full-stack developer in the MERN stack but enjoy most using my design skills to produce elegant and responsive web applications. In my free time I make beats.

• 🔭 I’m currently working on sharpening my JS skills
• 🌱 I’m currently learning the Material UI library
• 📫 Reach me by mail: [email protected]
• ⚡ Fun fact: Hippos have pink milk (for real)

hitlist's Issues

light mode bug

when you set the app on light mode and refresh the page it's turns back to dark mode

step to reproduce:

1. change to light mode
2. refresh the page

expected result:
stays in light mode

acrual result:
change back to dark mode

Client review

👍👍👍

• Spinner
  From what I saw spinner is handled correctly, but will spin forever if a request fails.

👎👎👎

• Client server communication
  Changes in client should only occur after the server send an OK response.

• Error handling
  Couldn't find where errors are handled.

@davidbinneun
@TomerNissim

Priority display bug

when you add a long word to the task the priority background is not on all the task div
steps:
1 - click on add task
2 - the task adds to the list

expected result:
the priority background height is the same size as the div height.

actual result:
the priority background height is smaller than the same size as the div height.