davideast / angular-universal-express Goto Github PK

Under the Server step, you say create a server folder with index.js inside of it. But then under the run step, you're running it from dist-server/index.js

Are we running the index.js from inside the dist-server folder that we created from the CLI Story?

index.ts

• readFile$ use of Observable.create() should return a teardown function.
• instead of mergmap(...).take(1), why not use switchMap(...) ?
• do you need to unsubscribe in angularUniversal() to prevent memory locks ?

Under the Server Build step, you say to delete dist/index.html and then, without any additional instruction, you have in the index.js file,

index: `path/to/index.html',

This is kind of confusing...are we deleting the file or not?

I am trying to use this package with Angular 6 and RXJS 6.2 but it looks like its not compatible