davidecarvalho / demolay-event-management Goto Github PK

Okay, now that I'm not beeing pushed to deploy it ASAP, I can start to take care of the things i've done. I'll try to make a more react-ish approach:

• Components are too big, need to make them smaller
  • Entrada Component
  • Comprar Component
  • Caixa Component
• Review how components are connected with Redux
  • Put redux properties inside an object called props;
  • Put component inner state inside an object called state.
• Route components are beeing used as containers, and its passing EVERYTHING to the child components, this is making the components hard to maintain
  • See which child components can be container components;
  • Route components MUST NOT be containers, they are just High Order Components, and their object is just to compose the view.
• Some actions are using getState from redux-thunk, this is a really bad practice, 'cause make testing actions really hard:
  • Review actions logics, so they become responsable for only one stuff, or compose actions with other functions inside it, breaking the logic into various functions.
• Since I cannot test web-components behavior with stuff like mocha or jest, I can at least test redux behavior
  • Test actions
  • Test reducers
• Change from realtime database to Cloud Firestore

And if everything is alright, I can think in something to test the components, something like Cypress