Off by one issue in function styleSelectedText about redmine_shortcuts

[davidegiacometti]

@jcormier
You're absolutely right.. My solution is wrong and your patch is working fine!
I have fixed the 0.5.3 with the correct code.
Thank you for the contribution! 😃

[davidegiacometti]

Hi @jcormier
Nice catch!
This is affecting only textile and looks related to the </pre> tag.
I am going to release a bug fix.

[jcormier]

While your patch works, I still think it's wrong and very hacky. I don't see any reason that selectionEnd would depend on the length of the text added after the selection, these offsets are all relative to the start of the text box, it should only depend on the prepend length as my proposed patch does.

Only the slicing really cares about the length of the append text...

[davidegiacometti]

The selected text on the textarea depends on both prepended and appended tags.

• Create a new issue and focus the text area
• Write some text
• Select the text (CTRL + A)
• Add the preformatted tags (CTRL + P)
• The entire text is selected

[jcormier]

Existing Text - Selected start = 0, end = 13

After pre

pre text - pre.length = 8
Existing Text - Selected start = 0 + 8, end = 13 + 8
post text - post.length = 9

It doesn't matter how large post text is, the selection start/end positions stay the same

[jcormier]

Note: Should have added +1 to pre and post lengths for newlines..., but it doesn't change the math.