davidegiacometti / redmine_shortcuts Goto Github PK

I really like your plugin, but there are some shortcuts that make me don't want to use it at the moment, like copy and delete....

Could you implement a plugin configuration so that the administrator can enable/disable each shortcut globally?

A simple settings page with the shortcut and checkboxes would suffice (of course, those settings must then be saved and read, and the javascript must check it and the help dialog should show only the enabled shortcuts).

Error: GET http://wanda:10083/redmine_shortcuts/help

Should be http://wanda:10083/redmine/redmine_shortcuts/help

Note: redmine_jstoolbar_ext uses the following js code to find the correct base URL.

    var base_url = $("head link[rel='stylesheet']:first").attr('href').replace(/stylesheets.+$/, '');
    var attachments_url = base_url + 'attachments/download/';

Hi,

thanks for the rgeat plugin.

I have a bug report: When pressing Ctrl+c to copy a text string from a page, the "Ticket copy" action get's triggered.

This should be prevented.

Thanks,
Tobias

In order to give some input and thank you for your work done on #8, I will add a PR with Polish localization in a moment

Hi,
I've just started using this plugin and I really like it. I would like to propose a improvement and would like to know if this is something you'd be interested.

I would like that if user presses the "?" key, we get the help (pretty much what happens on Github out of any textarea). Would you be interested in adding integration with https://github.com/impressivewebs/QuestionMark.js to do this? If you agree, I could start working on this and submit a PR.

In latest redmine, ctrl-shift-p is used to shift between edit and preview panes. The shortcut appears to also be triggering this plugins ctrl-p shortcut and adding pre tags.

Hello @davidegiacometti,
Thank you for developing this plugin, I really like it and found it very useful!

The only thing I miss is a "Code" shortcut. Would it be possible to add it as e.g. Ctrl/Command+@ a.k.a. Ctrl/Command+Shift+2?

Thanks,
Piotr

On the Redmine authorization page, the field of remembered logins "jumps" this happens 10 times (similar visual error behavior is observed only in FireFox and Safari).
Perhaps this is due to the parallel installation of the plugin Shortcuts and PlantUml, but I'm not sure.
Our engineer suggested such a solution, it's work:
--- redmine_shortcuts/assets/javascripts/view_layouts_base_body_bottom_questionmark.js 2021-06-03 21:08:20.171967086 +0000
+++ view_layouts_base_body_bottom_questionmark.js 2021-06-03 21:09:24.074637694 +0000
@@ -3,7 +3,9 @@
$questionMarkModal = $('

selectionEnd was being set 1 greater than expected for ctrl-p, so you would end up with something like below when you started typing.

<pre>
asdf</pre>

The code should use prepend.length when calculating selectionEnd

--- view_layouts_base_body_bottom_textile.js.orig       2021-11-15 13:50:15.822980038 -0500
+++ view_layouts_base_body_bottom_textile.js    2021-11-15 13:50:38.928515973 -0500
@@ -11,13 +11,13 @@
         textarea.val($content);
         textarea.focus();
         textarea.prop('selectionStart', $start - prepend.length);
-        textarea.prop('selectionEnd', $end - append.length);
+        textarea.prop('selectionEnd', $end - prepend.length);
     } else {
         $content = $content.slice(0, $start) + prepend + $content.slice($start, $end) + append + $content.slice($end, $content.length);
         textarea.val($content);
         textarea.focus();
         textarea.prop('selectionStart', $start + prepend.length);
-        textarea.prop('selectionEnd', $end + append.length);
+        textarea.prop('selectionEnd', $end + prepend.length);
     }
 }