davidtheclark / focus-group Goto Github PK

It really should, and the docs say it should. So there.

How do you feel about an onFocus callback? So if you have an element that can't receive focus you can add a class yourself or handle the state in something like React and apply a style. I'm trying to build a combobox right now and need to have a fake focus group so the input can remain focused, but still allow choosing a result. Thoughts? I can put together a PR if you like the idea. Maybe something like this?

onFocus: options.onFocus || function (member) {
  focusNode(member.node)
}

Then it would be the user's responsibility to handle focusing the element however they wanted.

edit

Realized this can't be solved with just a callback. I'm guessing another option like groupNode would be required to determine what the focus group is. Any ideas on that?

Do you think the document listener should be delegated? Then there is only one listener rather than a listener for every Focus Group. I can PR if you would like.

Found this error after doing a fresh NPM install. Any ideas to fix it?

Can we just use a local variable since we only use options.keybindings in the constructor?

How do you feel about allowing more ARIA keyboard controls for these options? Things like pageUp and pageDown? More can be seen here in the keyboard control section: https://www.w3.org/TR/2013/WD-wai-aria-practices-20130307/#accordion

I'm glad to do a PR for this as well if you would like :) maybe rename them to something like nextControls and prevControls?

I've been shifting my focus away from UI development, so don't plan on addressing new issues myself. If you use this library and want to see development continue, you can make that happen by becoming a co-maintainer — with permissions to triage issues, merge PRs, cut releases, etc.

Please comment below if you're interested!

Another possibility is for a dedicated owner to fork this code and create a new package. I'd be happy to link to that library from the README of this one.