davosmith / moodle-assignsubmission_pdf Goto Github PK

Good Day, the latest commit dcc908e to master removed compatibility with Moodle 2.5 and only works with Moodle 2.6. Could you please create a new branch with the previous d4a8a40 commit that still works with Moodle 2.5?

Thank you,
James

I upgraded moodle to 2.7 and forget to check if this module was available. Will it be available to 1st September?

Thanks

Thanks for the great plugin. Just been testing on Moodle 2.7 and appears to work fine, but I am getting some warnings when debugging shows notices.

When saving a submission receive this:

events_trigger() is deprecated, please use new events instead
line 283 of /lib/deprecatedlib.php: call to debugging()
line 367 of /mod/assign/submission/pdf/locallib.php: call to events_trigger()
line 5672 of /mod/assign/locallib.php: call to assign_submission_pdf->save()
line 5741 of /mod/assign/locallib.php: call to assign->save_submission()
line 395 of /mod/assign/locallib.php: call to assign->process_save_submission()
line 53 of /mod/assign/view.php: call to assign->view()

And when submitting PDF feedback receive this:

Invalid get_string() identifier: 'feedback' or component 'assignment'. Perhaps you are missing $string['feedback'] = ''; in mod/assignment/lang/en/assignment.php?
line 293 of /lib/classes/string_manager_standard.php: call to debugging()
line 6926 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 572 of /mod/assign/feedback/pdf/locallib.php: call to get_string()
line 68 of /mod/assign/feedback/pdf/editcomment.php: call to assign_feedback_pdf->edit_comment_page()

Hi Davo,

i have updated Moodle 2.4.7 to 2.6.0 without installing the plugins "PDF Submission and Feedback". the new editpdf functionality works great but i miss the old annotated submissions in the grading table !

I have installed the plugins and got this error:

Strict Standards: Declaration of assign_submission_pdf::submit_for_grading() should be compatible with assign_submission_plugin::submit_for_grading($submission) in C:\xampp\htdocs\moodle247\mod\assign\submission\pdf\locallib.php on line 801

When i change the parameter in function submit_for_grading($submission) in submissionplugin.php to submit_for_grading(stdClass $submission = null), it works!

How can i restore old annotated submissions without installing the plugins?

Do you have an idea?

Thanks
Majd