GithubHelp home page GithubHelp logo

Comments (7)

MawiraIke avatar MawiraIke commented on May 28, 2024

The tasks from this issue are:

  • Create an actual right click instead of embedded popup
  • Change option to open path in current inspector to use double click
  • Add option to open new path in new inspector
  • Add button to open the parent path in the current inspector
  • Add button to clear the path

from re-frame-10x.

Gregg8 avatar Gregg8 commented on May 28, 2024

@MawiraIke I've updated the spec for item 2 above ^^^

Note: we're skipping the "history of paths with step back and forward functionalities" feature

from re-frame-10x.

MawiraIke avatar MawiraIke commented on May 28, 2024

Got it @Gregg8 .
I have updated the PR #350 with the new features.

from re-frame-10x.

Gregg8 avatar Gregg8 commented on May 28, 2024

Nice improvements. Love the parent path and clear path buttons.

Some feedback:

  • The right-click menu appears about 700px to the right for me.
    • The red arrow is pointing to where I right-clicked:
      image
  • Middle-click to open the path in a new inspector is great. A couple of suggested improvements:
    • In Chrome, this changes (not all the time, not sure of the exact circumstances) the UI to scroll mode (and the cursor changes to a scrolling cursor). Need to click away to get out of it. I believe this could be prevented with a preventDefault call at the end of the click event handler
    • The inspector is closed by default. Open would be better, I think

from re-frame-10x.

MawiraIke avatar MawiraIke commented on May 28, 2024

Thanks @Gregg8 for the feedback. The issues you mentioned above are in continuous development and the second one regarding middle click triggering scroll mode should be fixed in the latest release 1.2.4.
I will update on the rest here after committing their fixes.

from re-frame-10x.

MawiraIke avatar MawiraIke commented on May 28, 2024

@Gregg8 the remaining two issues should be fixed on PR #356 waiting to be merged.
That is:

  1. The right-click menu appears about 700px to the right. This should be fixed and the menu should show to the immediate right of the mouse click - as if anchored by its top left corner.
  2. The inspector is closed by default. I have added an option in settings that allows users to choose the default behavior that will affect all new inspectors created.

from re-frame-10x.

Gregg8 avatar Gregg8 commented on May 28, 2024

Tested 1.2.6:

  1. Thanks. This is much better than before. However, instead of anchoring the popup menu to the position of the mouse pointer, it is anchored to the top-left corner of the object being clicked on, so if you click at the beginning of an object, it's sufficiently close the the mouse-click, but if you click near the end of a long object name, it appears quite far to the left of the mouse-click. In the image below, the arrow points to the caret, which is where I clicked...
    image
  2. Great

from re-frame-10x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.