Comments (7)
The tasks from this issue are:
- Create an actual right click instead of embedded popup
- Change option to open path in current inspector to use double click
- Add option to open new path in new inspector
- Add button to open the parent path in the current inspector
- Add button to clear the path
from re-frame-10x.
@MawiraIke I've updated the spec for item 2 above ^^^
Note: we're skipping the "history of paths with step back and forward functionalities" feature
from re-frame-10x.
Got it @Gregg8 .
I have updated the PR #350 with the new features.
from re-frame-10x.
Nice improvements. Love the parent path and clear path buttons.
Some feedback:
- The right-click menu appears about 700px to the right for me.
- Middle-click to open the path in a new inspector is great. A couple of suggested improvements:
- In Chrome, this changes (not all the time, not sure of the exact circumstances) the UI to scroll mode (and the cursor changes to a scrolling cursor). Need to click away to get out of it. I believe this could be prevented with a
preventDefault
call at the end of the click event handler - The inspector is closed by default. Open would be better, I think
- In Chrome, this changes (not all the time, not sure of the exact circumstances) the UI to scroll mode (and the cursor changes to a scrolling cursor). Need to click away to get out of it. I believe this could be prevented with a
from re-frame-10x.
Thanks @Gregg8 for the feedback. The issues you mentioned above are in continuous development and the second one regarding middle click triggering scroll mode should be fixed in the latest release 1.2.4.
I will update on the rest here after committing their fixes.
from re-frame-10x.
@Gregg8 the remaining two issues should be fixed on PR #356 waiting to be merged.
That is:
- The right-click menu appears about 700px to the right. This should be fixed and the menu should show to the immediate right of the mouse click - as if anchored by its top left corner.
- The inspector is closed by default. I have added an option in settings that allows users to choose the default behavior that will affect all new inspectors created.
from re-frame-10x.
Tested 1.2.6
:
- Thanks. This is much better than before. However, instead of anchoring the popup menu to the position of the mouse pointer, it is anchored to the top-left corner of the object being clicked on, so if you click at the beginning of an object, it's sufficiently close the the mouse-click, but if you click near the end of a long object name, it appears quite far to the left of the mouse-click. In the image below, the arrow points to the caret, which is where I clicked...
- Great
from re-frame-10x.
Related Issues (20)
- [Bug]: goog.ui usage incompatible with shadow-cljs 2.22.0 and google-closure-library v20230227 HOT 4
- [Bug]: highlight.js/lib/languages/gml.js error HOT 1
- [Bug]: "Set literal contains duplicate key" when `*print-length*` is set HOT 2
- [Enhancement]: Find a key in a map more easily.
- [Bug]: "guide me to greatness" did not guide me to greatness HOT 1
- [Bug]: traced-result is always nil
- [Bug]: 10x crashes with console error: Invalid number HOT 6
- [Bug]: Unable to load in combination with shadow-cljs HOT 2
- [Enhancement]: clarification in docs
- [Bug]: Sorting an app-db view with non-comparable keys crashes re-frame-10x HOT 3
- [Bug]: The required namespace "day8.re-frame-10x.preload.react-18" is not available. HOT 4
- Performance improvements - remove garden/spade? HOT 7
- [Bug]: Pop-out no longer working HOT 4
- [Bug]: build warning after 1.9.7 update
- [Bug]: latest 1.9.8 causes reagent/react console warning for non unique elements HOT 3
- [Enhancement]: Shortcut to pop out to window
- [Bug]: ignored-events in project configuration are ignored. HOT 2
- [Enhancement]: Update sidebar css + settings
- [Bug]: I can't expand maps under 3 keys even when the data is long. HOT 3
- [Bug]: React 17 render still used in popup
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from re-frame-10x.