dbfx / laravel-strapi Goto Github PK

By default they all point to https://github.com/vendor_slugpackage_slug/issues/new when really they should be https://github.com/dbfx/laravel-strapi/issues/new

When creating new commits the various tools that run over the code before a commit default to PHP 7.4 and cause the checks to fail because there are features in the code that PHP 7.4 doesn't support (Union types for example.

Also, PHP 7.4 has been end of life since 2022, is it really worth the effort to maintain compatability at the expense of new features?

Discussed in #15

Route::get('/test', function () {
    $strapi = new LaravelStrapi();
    return $localites = $strapi->collection('api/localites');
});

//Route pour 1 localite
Route::get('/test/{id}', function ($id) {
    $strapi = new LaravelStrapi();
    return $localites = $strapi->entry('api/localites', $id);
});

Installed version: v4.0.1

The cache key is using the encrypt() function which returns every time a different hash string in all the LaravelStrapi class methods,

$cacheKey = self::CACHE_KEY.'.'.__FUNCTION__.'.'.encrypt($endpoint);

The cache::remember always stores in the cache the same request but with a different $cacheKey

Proposal to fix the bug:

• Using md5: $cacheKey = md5(self::CACHE_KEY . '.' . __FUNCTION__ . '.' . $endpoint);
• Using sha1: $cacheKey = sha1(self::CACHE_KEY . '.' . __FUNCTION__ . '.' . $endpoint);