dcbia-ortholab / easyclip-extension Goto Github PK

When surface models (stl or vtk format) are loaded into Slicer 4.11, we can orient them in the Slicer Coordinate system following our protocol described by Ruellas in 2016.
When the oriented files are saved and later uploaded back in Slicer, we must now select the coordinate system as RAS. However, if we edit the surface model files with EasyClip and save them in Slicer, when we upload them once again in Slicer they are flipped 180 degrees (anterior shows as posterior) and it does not make a difference if we upload them as LPS or RAS orientation, they are always flipped.

Please see video recording saved to google DCBIA/KitwareSlicerextensionswork/VIDEOS on BUGS

cc: @jcfr @bpaniagua @JEHoctor @aruellas

Opening the module without any data loaded, then perform no action, and closing slicer, produces a memory leak in vtkCollection.

Slicer closing print messages:

Switch to module:  ""
Switch to module:  ""
vtkDebugLeaks has detected LEAKS!
Class "vtkCollection" has 1 instance still around.

If something more useful is done, for example, creating three planes and clip, this is the result:

Switch to module:  ""
ctkSliderWidget::setSingleStep()  6.71768 is out of bounds. 58.0057 64.7234 61.3645
ctkSliderWidget::setSingleStep()  6.71768 is out of bounds. 58.0057 64.7234 61.3645
ctkSliderWidget::setSingleStep()  6.71768 is out of bounds. 58.0057 64.7234 61.3645
ctkSliderWidget::setSingleStep()  6.71768 is out of bounds. 58.0057 64.7234 61.3645
Switch to module:  ""
vtkDebugLeaks has detected LEAKS!
Class "vtkCollection" has 4 instances still around.
Class "vtkObserverManager" has 1 instance still around.
Class "vtkIntArray" has 3 instances still around.
Class "vtkMRMLModelNode" has 1 instance still around.
Class "vtkTagTable" has 1 instance still around.
Class "vtkCommand or subclass" has 3 instances still around.
Class "9vtkBufferIiE" has 3 instances still around.

Hi, It seems that the easy clip is not loading in the 3D Slicer preview releases.

@JuliaLopinto To avoid confusion, could you delete your project JuliaLopinto/EasyClip-Extension and re-fork the one hosted in the DCBIA-OrthoLab organization. See https://github.com/DCBIA-OrthoLab/EasyClip-Extension

The fork graph currently shows this:

@fbudin69500 : Could you do the same ?

Thanks 🙏

After the clipping operation, and when there are multiple open boundaries in the 3D model created by that clip, the close open boundary algorithm creating back a solid shape does not work - only the smallest simple connected boundary opening gets closed.

Maybe this could be solved by keeping record of all points in all new boundaries created by the clipping and making sure (via their neighbourhood polygons?) that they are no longer part of an open boundary after the close open boundary step.

When closing the scene once the clipping planes disappear and the only way to use again the extension is to re-load the whole Slicer application.