ddanier / django-openx Goto Github PK

What steps will reproduce the problem?
1. Get a banner instance: b = banner.Banner.get(1)
2. Get banner daily statistics: b.daily_statistics()
3. Return xmlrpclib.Fault

What is the expected output? What do you see instead?
It should return a list data.

What version of the product are you using? On what operating system?
The last version. python2.6 ubuntu11.04


Please provide any additional information below.
Attached a patch here. Fixed now.

What steps will reproduce the problem?

   1. Instantiate a Banner object b
   2. Assign the necessary values to b.whatever
   3. Call b.add()

What is the expected output? What do you see instead?

   I expect the code to continue on.
   It does create the banner in the OpenX DB but the code hangs.

What version of the product are you using? On what operating system?

   Downloaded the version current in SVN as of Jan 18, 2010.
   Mac OS X.

Please provide any additional information below.

   I suspect that there is a coding error. Line 15 in banner.py:

        if 'aImage' in self:

   creates a loop. Python passes in a sequence of integers to Banner.__getitem__
   The call always returns None instead of an IndexError.

   (This same error occurs with the Banner.modify() method.)

As a matter of interest why are you deleting the aImage value from the data 
bucket? Is that just to free up the memory?

>>> from django_openx import Zone
...
  File "advertiser.py", line 5, in Advertiser
    _client = OpenXClient().advertiser
TypeError: __getattr__() takes exactly 1 argument (2 given)

I think it is time to update v1 to v2. It made me confused at the first time.

Replace
OPENX_URL = 'http://www.your-openx-server.tld/www/api/v1/xmlrpc/'
to
OPENX_URL = 'http://www.your-openx-server.tld/www/api/v2/xmlrpc/'

Thanks.