GithubHelp home page GithubHelp logo

searchmatchtextblock's People

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

searchmatchtextblock's Issues

Foreground isn't inherited

Nice control, I'm using it very successfully! However, there's a bug in HighlightingTextBlock.GetRunForText():

    private Run GetRunForText(string text, bool isHighlighted)
    {
        var textRun = new Run(text)
        {
            Foreground = isHighlighted ? HighlightForeground : Foreground,
            Background = isHighlighted ? HighlightBackground : Background
        };
        return textRun;
    }

By setting Foreground or Background on the Run, you're stopping it from inheriting from Foreground in the visual tree. This means that, for example, a selection bar in a DataGrid will no longer change the background color when a search string is present. Here's a corrected version:

    private Run GetRunForText(string text, bool isHighlighted)
    {
        if (isHighlighted)
        {
            return new Run(text)
            {
                Foreground = HighlightForeground,
                Background = HighlightBackground
            };
        }

        Run r = new(text);

        var vs = DependencyPropertyHelper.GetValueSource(this, Control.ForegroundProperty);
        if (vs.BaseValueSource != BaseValueSource.Inherited)
        {
            r.Foreground = Foreground;
        }

        vs = DependencyPropertyHelper.GetValueSource(this, Control.BackgroundProperty);
        if (vs.BaseValueSource != BaseValueSource.Inherited)
        {
            r.Background = Background;
        }

        return r;
    }

This version checks if the local value is set locally (not inherited) before setting it. I tested this in DataGrid and it works as expected.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.