debracupitt / colmaracademy Goto Github PK

https://github.com/dcupitt/colmaracademy/blob/master/index.html#L3-L8

Remember to include the viewport meta tag to properly control your website's viewport width.

<meta name="viewport" content="width=device-width, initial-scale=1.0">

https://github.com/dcupitt/colmaracademy/blob/master/index.html#L20-L31

You may not need to surround all of your a tags within span tags, since both a and span are inline tags.

If they're extra, consider removing them to remove any extra clutter from your codebase.

https://github.com/dcupitt/colmaracademy/blob/master/index.html#L28-L31

Nice job giving all of your img tags an alt attribute with a value that adequately describes the image, just in case your website is not able to load it.

Doing so will help improve the accessibility of your website, which might be accessed by visually impaired users on e-readers or other devices that might deliberately neglect images-- as well as any other time that your website is just unable to render images.

https://github.com/dcupitt/colmaracademy/blob/master/resources/css/index.css#L148-L167

Awesome job using this hover effect 👍

It would've been very easy to just give these sections a darker background color statically, but the intention of the design was definitely that certain sections of the page should somehow react to being interacted with by the user.

Even if these links or sections don't actually lead anywhere, it's important to have this sense of interaction for a modern site.

https://github.com/dcupitt/colmaracademy/blob/master/resources/css/index.css

Great job getting this website to respond gracefully 👍

You really nailed the breakpoints and media queries and made great use of relative font-sizes and widths.

Satisfactory 👍

You did a great job writing a fully mobile responsive website!

At this point, all you've got left to do is work on small details. See if you can make your code more efficient or easier to read. The less code the better, and this is especially true in CSS.

Also, just for practice you should see if you can make some nice mobile versions of your previous sites. There's no reason you shouldn't leave this program without a full portfolio mobile responsive websites!

https://github.com/dcupitt/colmaracademy/blob/master/index.html#L19-L24

Nice job using nav here to make your markup more semantic.

Try to go the extra mile and add more semantic elements, like: header, main, section, menu, figure, footer, etc. These can all make your markup a lot easier to read and reason about.