Comments (2)
crotru
commented on May 20, 2024
1
You're right @lauthieb,
I was indeed assuming the 62.5 trick was implemented,
but it's not really needed inside a design-system project since values are not subject to be easily changed by devs π
I close the issue
from vitamin-web.
lauthieb
commented on May 20, 2024
Hi @crotru!
Thanks for reporting this issue.
FYI, we follow this guideline: https://www.decathlon.design/726f8c765/p/061870-layout/t/98b2d9
In most browsers, 1rem = 16px, so I feel disagree with your "0.25rem => 2.5px".
Cf. this table: https://gist.github.com/trevorgreenleaf/0aef4a3c33cdc8011affb170cef4384c
So, in my opinion, 0.25rem => 16px * 0.25 = 4px.
I don't see any font-size: 62.5%; inside our packages/css/lib/index.css generated.
Maybe, I'm wrong. What do you think please?
from vitamin-web.
Related Issues (20)
- bug(@vtmn/icons): icons are displayed outside of viewBox HOT 2
- bug(@vtmn/react): missing icons HOT 1
- bug(@vtmn/svelte): `VtmnNavbarLink` is not SSR compliant HOT 1
- docs: typeface is now deprecated HOT 3
- bug: Allow label in Input to be a component rather than a string
- bug: the thumb of the `Toggle` component doesn't have the right color in dark mode
- bug(`@vtmn/css`): The placeholder a cropped on the VtmnSearch
- feat(`@vtmn/svelte`, `@vtmn/vue`, `@vtmn/react`): add summary as slot for `VtmnAccordion`
- bug(@vtmn/css): `VtmnRating` stars out of the box with many reviews. HOT 3
- feat: enhancement `VtmnCard` variant for SSR HOT 2
- feat: improve the `VtmnIcon` in order to used SVG HOT 9
- bug(@vtmn/react): VtmnQuantity "-" and "+" buttons should not validate form instantly HOT 1
- feat(@vtmn/css): enhancement `VtmnSelect` make the props label optional HOT 1
- bug(@vtmn/react): Having warnings "fail to parse source map" using React / TSX HOT 2
- bug: wrong behaviour on the `VtmnChip`
- bug(@vtmn/svelte): linear progressBar not displayed correctly on storybook HOT 2
- feat(@vtmn/css): be able to choose the duration of display for snackbar (& toast) HOT 3
- feat(@vtmn/css, @vtmn/react, @vtmn/svelte, @vtmn/vue): Improve `VtmnAlert` component HOT 6
- bug(@vtmn/css): display issue for the vtmn-select_container when the text are too long
- bug(@vtmn/vue): `VtmnQuantity` component is broken when we click the plus button
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitamin-web.