decentraland / agora

📝Agora is an off-chain governance tool for decentralized communities.

Marketplace

Decentraland's Marketplace

Frontend

The Marketplace is a React static site. Its code can be found under the /webapp directory.

Backend

It can be found under /indexer.

How to contribute

Contributing to the Marketplace is easy, you just need to go through the following process:

1. Look for issues in the Issues tab or create a new one with the proposed changes. We classify issues with the “Enhancement”, “Bug” or “Good first issue” tags. Feel free to check one of those first.
2. Contact team members via the GitHub issue or use the Code Contribution Discord channel. It’s important to at least check on the issue status before starting.
3. Set up your GPG key and sign all commits in your branch.
4. Read the testing standards and the coding standards to produce code that fits the project standards.
5. Create a PR with the changes, linking the PR to the created issue. If there are visual changes in the PR, attach images.

Copyright & License

This repository is protected with a standard Apache 2 license. See the terms and conditions in the LICENSE file.

agora's Issues

Count votes according to voting power (holdings) of assets

1. If an ERC20 holder has 10,000 tokens his voting power should be that number.

2. Keep track of his balance, if the funds are transferred away the new balance should be reflected accordingly.

Remove Partial Results column

We already know when a Poll is closed by changing the way the results look.

Sort Poll entries by contributions descending

Query balanceOf on the frontend for tokens

Use timestamp for Vote date

Show closed/expired polls

Restore MANA balance in account badge

Add event logging

Add an indication of the total voting power available for a poll

This would be the total minted tokens.

Same sort order for all options

Sort options & votes in the backend

Currently we sort options by value and votes by timestamp on the UI, but we should do this on the backend because we need to add several .sort's in the UI and if we miss them that could lead to inconsistencies between screens

Add a min width to progress bar results

Some results have a very small percentage (or no percentage at all if it has no votes) and they don't show up or are too narrow to be readable.

All addresses should be transformed to lower case before inserting them on the database

Mobile layout glitches in the Poll Page

Contributions not validated server side

Exploited on Amusement Park's start up plan. Simply modified the signed message to have 100 contributions instead of undefined and submited. Server accepted as valid vote!

Add pagination to votes component

Remove any use of hardcoded MANA token

Vote Page

API endpoint to save a vote

• Validate that poll and option exist
• Validate signature format
• Extract account address info from signed message

Tooltip with precise time when hovering over the closing date

Add poll.text + poll.description and option.value to the signed message

Create a staging environment (server)

Monitor to update the current balance of a Token for an Account

An approach for this monitor could be implemented watching Transfer() events on the related Account for to the token used for voting.

Another approach is to issue a getBalance(voter_address) for all the addresses that voted, this would require a refresh scan every once in a while.

Remove `isDCLPoll` and `isDCLToken`

Currently we have two helpers isDCLPoll and isDCLToken that both can be replaced in favor of isDistrictToken from src/modules/token/district_token/utils.ts

Disable click can be clicked

When is not connected you can click on cast vote button and will refresh the page e.g: https://agora.decentraland.org/polls/f33a9509-5a52-4248-9dc8-d073e3beea50

Poll Detail Page

Make links clickable

Make links clickable

Progress bar position and style

Fix PollDetailPage with no votes

The table and progress bar both break

Footer including language settings

Support setting a start_date for the poll

This time will work by hiding the poll from public access until now() > start_date
It will help to preload many polls in advance and make them start at a future date.

Remove "Token" section from District polls

Remove "Token" section from District polls

Show disabled button when no voting available

Componentize "Cast your vote" and "Your vote"

Currently we have two pieces of code repeated in ParcelDetailPage that we should componentize:

Cast your vote

{isFinished(poll) ? null : (
  <div className="vote">
    <Link
      to={locations.voteDetail(poll.id)}
      className={!isConnected ? 'disabled' : undefined}
    >
      <Button primary disabled={!isConnected}>
        {t('poll_detail_page.cast_vote')}
      </Button>
    </Link>
  </div>
)}

Your vote

{currentVote ? (
  <span className="your-vote">
    {t('poll_detail_page.you_voted', {
      option: getVoteOptionValue(poll.options, currentVote)
    })}.{' '}
    <span className="time-ago">
      {distanceInWordsToNow(currentVote.timestamp)}.
    </span>
  </span>
) : null}

Add fake tokens to districts

API endpoint to fetch the history of votes for a poll

remove `console.log` and replace `event` with `_`

remove console.log and replace event with _ in ParcelDetailPage

Remove submitter column

Markdown support for Poll description

UI Fixes

• Remove headers from tables in table/mobile, add titles intline

• Add bottom margin on mobile/table to fix scroll issue

• Fix progress bar in tablet -> bar + CTA don't fit in screen

Improve the API to choose if filtering all/active/archive polls

Rework landing page

Display results vertically in mobile

API endpoint to fetch a poll

<Token> component

Create a component to handle the logic of rendering the "Symbol + Amount or just Amount" depending on the token, so we can remove all those token.symbol === 'MANA' ? ... : ...

Define database model

• Poll
  • name
  • body
  • token
  • submitter
  • closes_at
  • created_at
  • updated_at
• Option
  • name
  • poll_id
  • created_at
  • updated_at
• Account (this is if we want to have some sort of profile)
  • address
  • name
  • email (?)
• Vote
  • poll_id
  • option_id
  • address
  • signed_message
  • created_at

Split homepage polls into Polls and District Plans

Split homepage polls into Polls and District Plans

Add a nonce to the signed message

Show final results of the Poll when closed

Add Poll.description to the message signature