Comments (5)
@SherifWaly Right now, in the Organizations -> Teams -> Projects flow, 2 requests are passed: the one that is built along the way, and the original one (entry point, which is encapsulated by VersionEye). This is because, for instance, the Projects API starts the uri path from 0 again, instead of continuing it (it's not optimal, but it's how the API is designed).
Now, instead of passing 2 requests, we will pass 1 request (the one which is built along the way) and the VersionEye instance:
- the VersionEye instance will be returned by the versionEye() methods
- the VersionEye instance will have a default accessible method to fetch the original request. So a Project, when it needs the original request, will call
this.versionEye.request()
Makes sense?
And since VersionEye.request()
is package protected and cannot be on the interface, it will be on RtVersionEye
only. All the ctors will accept RtVersionEye
:D
Only do this change: replace that request with versionEye and write the RtVersionEye.request()
method. Puzzle out the actual implementation of Organization.versionEye()
, Team.versionEye()
etc. It's already enough stuff.
If you have any other questions, ask away :)
from versioneye-api.
done, thanks :)
from versioneye-api.
@SherifWaly want to do this? It shouldn't be so complicated :D
from versioneye-api.
@amihaiemil Ok, I would like to do it :D
Just I want to ask whether I should only pass the VersionEye instance so what about the request as it's built over the way :D ?
from versioneye-api.
@amihaiemil Ok, thanks for explaining :)
from versioneye-api.
Related Issues (20)
- RtRepositories.java:46-47: Refactor code to make the class... HOT 2
- Github.java:37-37: Complete Github API methods. HOT 2
- RtVersionEye.java:41-41: Implement versionEye() method for... HOT 2
- MkVersionEye.java:42-43: Continue implementing the mock API.... HOT 1
- Github.java:37-39: Complete Github API methods. When... HOT 10
- RtRepositories.java:46-48: Modify repository(repositoryKey)... HOT 5
- Throw UnsupportedOperationException for unimplemented methods HOT 1
- Security.java:40-42: Implement a way of fetching the... HOT 3
- VersionEye.java:37-37: Implement the Product/Products Search... HOT 4
- test HOT 1
- test HOT 1
- VulnerabilitiesPage.java:39-40: Unit test this class, similar to how... HOT 2
- Repository.java:35-36: Complete implementations and unit... HOT 6
- Github.java:38-40: Complete Github API methods and move... HOT 10
- RtGithub.java:46-46: Unit test this class. HOT 2
- RepositoriesPage.java:39-40: Write some unit tests for this class.... HOT 5
- Vulnerability.java:35-36: Implement and unit test the methods... HOT 2
- Add DELETE method for Project HOT 1
- Implement Project.update(File) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from versioneye-api.