GithubHelp home page GithubHelp logo

Comments (5)

amihaiemil avatar amihaiemil commented on June 20, 2024 1

@SherifWaly Right now, in the Organizations -> Teams -> Projects flow, 2 requests are passed: the one that is built along the way, and the original one (entry point, which is encapsulated by VersionEye). This is because, for instance, the Projects API starts the uri path from 0 again, instead of continuing it (it's not optimal, but it's how the API is designed).

Now, instead of passing 2 requests, we will pass 1 request (the one which is built along the way) and the VersionEye instance:

  • the VersionEye instance will be returned by the versionEye() methods
  • the VersionEye instance will have a default accessible method to fetch the original request. So a Project, when it needs the original request, will call this.versionEye.request()

Makes sense?

And since VersionEye.request() is package protected and cannot be on the interface, it will be on RtVersionEye only. All the ctors will accept RtVersionEye :D

Only do this change: replace that request with versionEye and write the RtVersionEye.request() method. Puzzle out the actual implementation of Organization.versionEye(), Team.versionEye() etc. It's already enough stuff.

If you have any other questions, ask away :)

from versioneye-api.

amihaiemil avatar amihaiemil commented on June 20, 2024 1

done, thanks :)

from versioneye-api.

amihaiemil avatar amihaiemil commented on June 20, 2024

@SherifWaly want to do this? It shouldn't be so complicated :D

from versioneye-api.

SherifWaly avatar SherifWaly commented on June 20, 2024

@amihaiemil Ok, I would like to do it :D
Just I want to ask whether I should only pass the VersionEye instance so what about the request as it's built over the way :D ?

from versioneye-api.

SherifWaly avatar SherifWaly commented on June 20, 2024

@amihaiemil Ok, thanks for explaining :)

from versioneye-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.