Github.java:37-39: Complete Github API methods. When... about versioneye-api

[amihaiemil]

By the way, I'm thinking to release the first version soon, in the next weeks - it has a good shape already, I think. Mock version is not finished, of course, but that can wait until later versions.

[amihaiemil]

@SherifWaly don't forget about PDD. I think the DELETE should work in 30 min, not sure if you have time for both. Puzzles :D

[amihaiemil]

@SherifWaly done here, thanks :)

[0pdd]

@amihaiemil please pay attention to this new issue.

[SherifWaly]

@amihaiemil I want to do this one.
I want to ask whether this would be a good design for the methods or not.
for GET, POST and DELETE /github/{repo_key} I think they should be implemented at Repositories as GET returns a more detailed information about the repository and I should make a class called for example DetailedRepository.

What do you think about that :) ?

[amihaiemil]

@SherifWaly hmmm... I think

1. DELETE should go in the Repository interface. So once the usre has a Repository, he can simply call delete() on it, without needing to get its id -- same as for a Project

2. GET /github/{repo_key} can go in Repositories, but do not make another class. The returned JSON will be animated by the existing implementation, which won't have all the needed methods, but it has the json() method which returns the raw content, with which the user can play. I'm affraid that having yet another class like DetailedRepository will be confusing.

3. POST /github/{repo_key} is an endpoint that I do not understand: why does it need to take a File input? If I give the repo coordinates and the token which has at least read access on Github, can't VersionEye look for it in the repository? It seems pointless, and I would leave this endpoint out for version 1... anyway, for file upload with jcabi-http we have to wait for a ticket to be resolved there, or find another way on our own :D

So, for now, only DELETE and GET.
Makes sense? What do you say?

[SherifWaly]

@amihaiemil Ok, let's start with DELETE and GET :D
I also forgot the /github/hook it's implemented in Project but I think it should be done here also, what do you think :D ?

[amihaiemil]

@SherifWaly I think it's perfect in the Project. Since no matter what, the user will have to fetch a Project first and get its id, and only after that, to look for the method in this interface... it's more procedural.

Like it's done now, he gets an instance of Project and sees "ok, I can hook THIS project, to Github".
Again, otherwise, he would have to do more steps, to get the same outcome.

[SherifWaly]

@amihaiemil Ok, so i will implement DELETE and GET methods

[0pdd]

The puzzle 101-27d97a0d has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil