demianriccardi / p5-role-serializable Goto Github PK

Should this be released as HackaMol::Roles::SerialRole?

it does not depend on HackaMol. The question is whether it useful for others or properly implemented.

Demian

re:

This module uses spew_raw and slurp_raw from PATH::TINY. Take the normal precautions for using slurp.

I'm entirely confused what this means. I'm an avid Path::Tiny user and have been a while, and I'm unfamiliar with what this warning is about, specifically why I need to know.

Especially as the Path::Tiny interfaces are not exposed to the user, and so they don't constitute part of the external API they have to actually think about, and its merely an internal implementation detail they aught not care about.

JSON::MaybeXS might be a better option than consuming JSON::XS directly.

Mostly because JMXS auto-proxies to all of:

• Cpanel::JSON::XS
• JSON::XS
• JSON:PP

Based on availability, slightly increasing the range of targets you can support.

I'd also suggest not loading all the encoders only to use one of them, and possibly avoiding a system of hard-coded conditionals working out how to encode/decode. ( Also, maybe steal parts from / maybe try using https://metacpan.org/release/Data-Serializer )