GithubHelp home page GithubHelp logo

denehyg / reveal.js-toolbar Goto Github PK

View Code? Open in Web Editor NEW
27.0 27.0 21.0 775 KB

Toolbar plugin for reveal.js

Home Page: https://denehyg.github.io/reveal.js-toolbar

License: MIT License

CSS 80.29% JavaScript 19.71%

reveal.js-toolbar's People

Contributors

denehyg avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

reveal.js-toolbar's Issues

Toolbar stops working after using overview button

When enabling the overview button in the toolbar, it works in the first instance, but when returning to full slide view, the toolbar is no longer accessible and requires a screen refresh to be accessible again. Have tested in chrome, firefox and safari.

Fullscreen Button not working

On Chrome und Chromium the Fullscreen-Button is not working. I'm getting an error-message in the console-view:
Uncaught (in promise) TypeError: Failed to execute 'requestFullscreen' on 'Element': parameter 1 ('options') is not an object.
at Object.request (screenfull.min.js:7)
at Object.toggle (screenfull.min.js:7)
at toolbar.js:99
at HTMLAnchorElement.button.onclick (toolbar.js:77)

There seem s.th. change with the fullscreen-api in Chrome last year (?)

Toolbar links trigger slide change

The toolbar buttons use <a href="#">. When clicked this results in reveal.js changing to the first slide. The plugin needs to capture the event before reveal.

Gettomg 'TypeError: RevealMenu.isInit is not a function' when I use fullscreen

I'm just trying top add the fullscreen option to my slide. But getting this error for RevealMenu. I tried adding menu in dependencies as well (though I don't need it). Still it shows. The full screen is working. Just that console shows this error.

toolbar: {	position: 'top',fullscreen: true, capturemenu:false}

image

Uncaught ReferenceError: head is not defined

Hi!
running the plugin with the current version of reveal.js (3.8) causes a Reference Error:

toolbar.js:41 Uncaught ReferenceError: head is not defined
at loadPlugin (toolbar.js:41)
at HTMLLinkElement.finish (toolbar.js:210)

Not 100% why, but does the plugin rely on head.js, which has been removed from reveal.js?

Remove dependency on menu as default

As discussed in #6, the toolbar currently expects the menu to exist as the default with the captureMenu: false option used to remove it. It would make more sense for captureMenu: false to be the default. This should probably need to wait for v1.0 as it will break backwards compatibility.

Menu button not moved to toolbar

Hi,

I use both plugins revealMenu and revealToolbar with reveal.js 4.2.1. But the menu button is not moved to the toolbar.

In the toolbar config I set captureMenu: true

Load plugins with:
dependencies: [{ src: 'plugin/toolbar/toolbar.js' }], plugins: [ RevealMarkdown, RevealHighlight, RevealNotes, RevealZoom, RevealMenu ],

In browser console I got:
Uncaught TypeError: RevealMenu.isInit is not a function at toolbar.js:189:42

Browser

Speaker notes does not start timer from toolbar

Using version 3.6.0 of Reveal JS and version 0.1.4 of 'reveal.js-toolbar'.

When I start the speaker notes with a running server (npm start) and I use the toolbar to open the speaker notes the timer does not start and the time stays '0:00am'.

Pressing the 's' key on the keyboard opens the speaker notes and the timer and time works as expected.

Issues with RevealMenu

So it looks like if you don't have RevealMenu added as a plugin then you get an error:

image

So I decided to add the RevealMenu plugin to see if it would fix the error and instead it generates a new error:

image

Is there any way to use this plugin without the RevealMenu plugin installed and also get no errors?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.