dependents / detective-typescript Goto Github PK

Hi there,

the README.md suggests running

npm install detective-typescript

Unfortunately there is no such package in the npmjs.com registry.

Could you please publish it or redirect me to the correct package?

Thanks!

Would be sweet to get a published release with cb1c37c <3

@XhmikosR

is there a chance, that new major version would be supported?

thank you for this excellent tool :)

I've been using this with a typescript application and today I added a tsx file and found that detective-typescript throws an error which looks like this,

{ index: 727,
  lineNumber: 48,
  column: 14,
  message: '\'>\' expected.' }

what is the best way to resolve this? will you publish this module to npm?

If your tsconfig.json has "module": "ES2020" or later (e.g you are outputting ESM and not CJS), TypeScript doesn't rewrite import './foo' to import './foo.js' in the transpiled output - instead you have to use import './foo.js' in your .ts file.

This module then breaks because it (quite reasonably) detects './foo.js' as a dependency which of course doesn't exist.

I've hacked round it by replacing the file extension here and here but it doesn't take into account if ./foo.js does actually exist and that's what you meant to import. I don't know the AST well enough to make that change, but a simple fs.existsSync should be enough?

Another workaround is to run the dep checker over the transpiled output instead of the ts source, but then you lose any import type declarations, so it's not ideal.

Refs: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#type-in-package-json-and-new-extensions

Ref dependency-check-team/dependency-check#112 (comment) I was wondering if could add support for a options.filename option here, which in this module, would auto-enable jsx:true if the extension of said filename was .tsx.

In package.json, version: "6.0.0" but actual version is "7.0.0".
It makes me confused.

Currently, given an import such as import { Foo, Bar } from './utilities', the returned dependencies will only give ['utilities'], and no other details about what specifically was imported.

For example, the previous import in the page.ts file:

// Directory Structure
├── page.ts
└── utilities
    ├── index.ts
    ├── foo.ts
    ├── bar.ts
    └── baz.ts

// utilities/index.ts
export * from './foo'
export * from './bar'
export * from './baz'

These details would be incredibly useful in other places such as dependency-tree so that the specific imports could be traced.

Currently when getting the dependencies for page.ts it would be utilities/index.ts, and utilities/index.ts would depend on foo, bar, and baz. This gives the appearance that page.ts depends on foo, bar, and baz, even though it only imports Foo and Bar.

I would be happy to PR this improvement to this package if this is an acceptable addition. When implementing it, I would add an opt-in config option to retrieve the extra import declaration data, and then pass it to the onAfterFile callback for use in other locations.

In some situations the detective fails to recognize ImportExpression (import('...')) that imports a tsx file. In that case the imports that are inside the file that got imported by that expression are not recognised.

Repository to reproduce the issue:
https://github.com/leanazulyoro/test_depscheck

1. npm install

2. npm run deps:check
   It will fail with Fail! Modules in package.json not used in code: lodash even when lodash is imported in TestFile2.ts

3. change the extension of TestFile.tsx to TestFile.ts and it works fine. So the issue might be in the @fatso83/detective-tsx package, that uses the typescript-detective's tsx version.