dequelabs / attest-release-scripts Goto Github PK

When testing out changes from #12, I noticed this:

~/dev/src/github.com/dequelabs/testing-repo on master ∴ CIRCLE_PROJECT_REPONAME=testing-repo CIRCLE_PROJECT_USERNAME=dequelabs ../attest-release-scripts/src/java-github-release.sh
Releasing v3.5.1
../attest-release-scripts/src/java-github-release.sh: line 10: CHANGELOG.md: No such file or directory

This isn't a blocker right now, but it will cause issues when we run the scripts on a new project.

Based on this discussion from here - https://github.com/dequelabs/attest-node-suite/pull/105#issuecomment-469717490

At some point, we may have to add some checks in dequelabs/attest-release-scripts:src/node-github-release.sh@develop (raw), to validate if a tag already exists and warn, to avoid us from overriding.

We have something like the following copied into countless repos. It'd be nice if we could just grab it (or something similar) from here rather than rewriting it for every new project.

#!/usr/bin/env node

const fs = require('fs')
const pkg = require('../client/package.json')

if (!process.env.CIRCLE_SHA1) {
  throw new Error('No CIRCLE SHA available.')
}

const next = pkg.version + '-next.' + process.env.CIRCLE_SHA1.substring(0, 8)
pkg.version = next
fs.writeFileSync('./client/package.json', JSON.stringify(pkg, null, 2))

See - https://github.com/dequelabs/attest-node-suite/pull/177#discussion_r276762762

auth-service (and potentially others) will soon be deploying two Docker images to ECR (a "regular" image for us to use in production and an "on prem" image for customers). We could support this by using the --suffix flag (--suffix=onprem), but ideally we'd just have separate ECRs (auth-service and auth-service-on-prem). In order to support this here, we should create an --ecr= (or --repo=?) argument which will override the {env}_ECR environment variables.