GithubHelp home page GithubHelp logo

dereuromark / cakephp-mailchimp Goto Github PK

View Code? Open in Web Editor NEW

This project forked from springest/cakephp-mailchimp-datasource

22.0 5.0 17.0 225 KB

CakePHP datasource for connecting to the mailchimp API ( http://apidocs.mailchimp.com/api/ ) as well as the Mandrill API ( https://mandrillapp.com/api/docs/ )

PHP 100.00%

cakephp-mailchimp's Issues

Upgrade to Cake3

Anyone up for the job?

I think for Cake3 it would be cool if

  • A more datasource type approach could be found so that you can also hook in validation etc.
  • More tests, obviously

MailchimpAppModel::call() should always return $this->response unless there is an error

Returning false in MailchimpAppModel::call() is problematic: the campaignCreate function returns an array with [..., 'status' => 'save', ...] when successful for example. So it succeeds, but because it has a status key, it still returns false although you then need the campaign id to send it. Maybe it should return $this->response anyway all the time as a last resort? I don't know enough how other functions normally react to decide on the best course of action.

2.x Problem using Mandrill templates.

In the MandrillTransport class its impossible to send a template that is stored on Mandrill without having a local template available. Which defeats the purpose of the Mandrill templates. The code on line 127 and line 85 also prevent you from passing template_content vars to Mandrill.

I'm not sure if this is by design or I'm totally confused on the usage of it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.