Comments (7)
Hello @arthurdenner! Thanks for the interest!
I am hesitant to export internals of the lib. If we did that, it would make it harder in the future to change them since we wouldn't know at that point who would be relying on them. Instead, what I might like is to update those internal functions with the equivalents from the date-fns lib like startOfDay
- https://date-fns.org/v1.29.0/docs/startOfDay which is equivalent to normalizeDate - and isEqual
- https://date-fns.org/v1.29.0/docs/isEqual. That was suggested in a different issue - #10
This way there wouldn't be duplicate code for this logic if you wanted to implement it in your own component that is extending <Dayzed>
. Plus we get the benefit of date-fns being a well tested lib.
What are you thoughts on something like this?
from dayzed.
@arthurdenner I think this is ready for you now. I added some integration tests around the lib using Cypress.io - #16. Let me know if you have any questions. Thanks!
from dayzed.
@arthurdenner date-fns
should be added to the dependencies
since the methods that will be used from it will be packaged in with the <Dayzed>
component dist bundle.
from dayzed.
Thanks for the answer. Your hesitancy makes total sense and switch to date-fns
would be a good solution. Can I work on a PR for this?
from dayzed.
Yes, a PR for this work would be great! If you are able to give me a day, I would like to add some tests to the lib that would make this refactor easier. I will ping you here when those tests have been added
from dayzed.
Nice, I'll wait for your signal then. Thanks!
from dayzed.
Thanks, @mkartchner994. I'm not so familiar with publishing packages on npm, so I'm wondering, date-fns
should be what which of dependency, a peerDependency?
from dayzed.
Related Issues (20)
- Proposal: Turn components in examples into reusable components HOT 3
- Rename fillAdjacentMonths to showOutsideDays HOT 4
- Provide option to go forward/backward a variable number of months HOT 3
- Move date-fns to dependencies HOT 6
- Compatibility with React 15? HOT 1
- Upgrade to use date-fns Version 2 HOT 3
- Pass the event to the onDateSelected callback HOT 5
- Unable to use useDayzed with typescript HOT 5
- A possible bug in @types HOT 2
- Fix unnecessary recalculations HOT 2
- Proper way to show dayzed-powered calendar alongside native date input? HOT 1
- How to change timezone? HOT 2
- Translate aria-labels HOT 3
- Would you be interested in a TypeScript version HOT 2
- [que[ - How to change date from outside of the calendar HOT 2
- Is there any possibility to include time selection along with date? HOT 2
- Changing offset with state HOT 2
- Incorrect handling of years 0000-0099 HOT 2
- Weekly view
- Internationalization of accessibility properties from getDateProps HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dayzed.