GithubHelp home page GithubHelp logo

Comments (7)

dkirkby avatar dkirkby commented on June 22, 2024

For background on this issue see desihub/desisim#93.

from desimodel.

sbailey avatar sbailey commented on June 22, 2024

I like get_specsim_config(), but should it return a yaml file, or the contents that would have been loaded from said yaml file? I think the latter is cleaner if that can be made compatible with specsim, since it doesn't involve making a temporary file just so that specsim can read it back in.

I had originally been thinking that we would provide a script in desimodel to convert its contents (including desimodel/data/desi.yaml) into a specsim_desi.yaml file that would also be kept in desimodel. But that requires humans to remember to update specsim_desi.yaml when desi.yaml is updated. Fragile. Doing it on the fly with get_specsim_config() is nice, at the cost of not having a file directly in github that is already the canonical file to use.

from desimodel.

weaverba137 avatar weaverba137 commented on June 22, 2024

@dkirkby, I'm assigning this to you so that you can assign it to someone who can resolve this issue.

from desimodel.

rainwoodman avatar rainwoodman commented on June 22, 2024

what about returning a dict instead of a file? It sounds strange to serialize and deserialize; plus the load_config API can't handle string input anyways.

import desimodel
from specsim.config import Configuration
specsimconfig = Configuration(desimodel.get_specsim_config())
...
...

from desimodel.

weaverba137 avatar weaverba137 commented on June 22, 2024

Can this be resolved so that we can create (or not create) a data model for the file(s)?

from desimodel.

dkirkby avatar dkirkby commented on June 22, 2024

I can take care of this but I'm not sure if this is still the direction we want to go. @sbailey ?

from desimodel.

weaverba137 avatar weaverba137 commented on June 22, 2024

We do want to move the filter curves over to desispec, but this is very low priority for now.

from desimodel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.