GithubHelp home page GithubHelp logo

Comments (10)

weaverba137 avatar weaverba137 commented on August 22, 2024

Check the newest tile file!

from desimodel.

schlafly avatar schlafly commented on August 22, 2024

Let me take this one; it looks like I have units in the ecsv file but not the fits file.

from desimodel.

weaverba137 avatar weaverba137 commented on August 22, 2024

OK, but I'll want to double-check things when you're done.

from desimodel.

schlafly avatar schlafly commented on August 22, 2024

Please see
https://desi.lbl.gov/svn/code/desimodel/branches/newtileunits/data/footprint/
As Stephen alluded to, it seems every time I touch this file the last few decimal digits change, but the values pass np.allclose(...) with respect to old values, so I'm declaring success. This version fixes a mis-unit in STAR_DENSITY and adds TUNIT keywords to the FITS file. It also adds a meta keyword to the ecsv tile with EXTNAME = TILES, reflecting the EXTNAME = TILES bit of the FITS file equivalent. This is basically an artifact of wanting to get EXTNAME = TILES in the FITS file and using the same astropy Table interface to write both files.

Thanks for double checking; feel free to merge if it passes your inspection.

from desimodel.

sbailey avatar sbailey commented on August 22, 2024

@weaver please double check this and then merge into trunk if it looks ok. Thanks.

from desimodel.

sbailey avatar sbailey commented on August 22, 2024

whoops I meant that for @weaverba137 . Apologies to the other weaver that I just pinged.

from desimodel.

weaverba137 avatar weaverba137 commented on August 22, 2024

I will try to get this done on Wednesday.

from desimodel.

weaverba137 avatar weaverba137 commented on August 22, 2024

By the way, there's no GitHub PR associated with this is there? The merge would be purely on svn, correct?

from desimodel.

schlafly avatar schlafly commented on August 22, 2024

Correct.

from desimodel.

weaverba137 avatar weaverba137 commented on August 22, 2024

OK, I'm going to merge momentarily.

from desimodel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.