Comments (7)
For context, desimodel.footprint.find_points_in_tiles()
uses desimodel.focalplane.get_tile_radius_deg()
for the default radius. This returns the radius of the middle of the outermost positioner, but as you found here that means that there are some targets that are reachable by some positioners that aren't included. This choice was motivated by people doing coverage statistics and not wanting to include too many points that couldn't actually be observed.
I'd be fine with updating desimodel.focalplane.get_tile_radius_deg()
to be the furthest radius that any positioner could reach and just accept that that will bring in a superset of targets that actually could be reached. I don't think we should try to update desimodel.footprint.find_points_in_tiles()
to do the exact per-positioner coverage calculation which would be much much slower (ok if someone wants to contribute that as a separate function; I have ideas about how that could be done...)
Any strong opinions either way from anyone about whether the tile "radius" should be referring to the maximum possible radius, or the typical radius?
This shows the radius of furthest reach of the positioners along the outer edge of the tile, along with the radius equivalent to what is currently considered to be the tile radius.
from desimodel.
I vote that it is updated to be the maximum possible radius to ensure that all targets will lie within reach of a positioner. I agree that this does not need to do the exact per-positioner coverage.
from desimodel.
Would be nice to show the tile perimiter in tile plots of the fiber assignment (a fine dashed-line circle superposed on the plots just so that we know if an "edge fiber" is left unassigned, it's not for any reason other than insufficient target density or fiber collision).
And, @sbailey: Agreed. clearly desimodel.focalplane.get_tile_radius_deg() controls the find_points_in_tiles() output so this is more of a "tile radius definition" issue than the find_points_in_tiles() issue. This ticket just shows how we reached to the conclusion about [possibly] changing the tile radius definition.
from desimodel.
Another note: In fiber assignment, the tile radius (which is used in the tree lookup to find available targets for each tile) is currently hard-coded to 1.65 degrees. This and all of the hardware properties will be reviewed after the merge when updating the positioner geometry, etc. That would be a good time to get this value from some other place like desimodel.
from desimodel.
For reference: https://github.com/desihub/fiberassign/blob/tsk_refactor/src/hardware.cpp#L94
from desimodel.
In fiber assignment, the tile radius (which is used in the tree lookup to find available targets for each tile) is currently hard-coded to 1.65 degrees.
The source of difference between hard-coded tile radius in hardware and what I see below is not clear to me:
import desimodel.focalplane
desimodel.focalplane.get_tile_radius_deg()
1.6057735024174122
from desimodel.
default tile radius updated in PR #102; closing this ticket.
from desimodel.
Related Issues (20)
- update xy2radec and radec2xy to support airmass field compression terms
- Add focalplane model support for stuck / broken position
- Add support for CANbus failures in focalplane model HOT 1
- Use instrument database for generating focalplane model HOT 2
- update/deprecate fiberpos.fits HOT 6
- DESIMODEL SVN data? HOT 2
- Update platescale to as-built design from DESI-4037 HOT 2
- Mechanism for getting current "nominal" focalplane HOT 1
- Convert focalplane model times to UTC
- Update throughput model to include dip between 4300 and 4500A HOT 3
- Add information about fibers with low transmission
- Outdated desimodel test branches. HOT 1
- astropy 5 not compatible with focalplane calibration ecsv HOT 13
- desiInstall desimodel branches/main fails
- Remove fix-tiles branch? HOT 1
- update psf-quicksim HOT 3
- Update api.rst
- Problem with new version of numpy HOT 5
- io.load_tiles defaults to old tile list $DESIMODEL/data/footprint/desi-tiles.fits HOT 6
- Error with get_tile_radius_deg when loading platescale HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desimodel.