desire456 / spring-course-1 Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 63 KB

Java 100.00%

spring-course-1's People

Watchers

spring-course-1's Issues

Упростить Programmatic Config

spring-course-1/src/test/java/ProgrammaticTest.java

Lines 22 to 38 in b81f632

 context.registerBean(PGSimpleDataSource.class, () -> { 

 PropertySource<?> propertySource = context.getBean(PropertySourcesPlaceholderConfigurer.class) 

 .getAppliedPropertySources() 

 .get("localProperties"); 

 PGSimpleDataSource dataSource = new PGSimpleDataSource(); 

 dataSource.setServerNames(new String[]{(String) propertySource.getProperty("db.serverName")}); 

 dataSource.setDatabaseName((String) propertySource.getProperty("db.databaseName")); 

 dataSource.setPortNumbers(new int[]{Integer.parseInt((String) propertySource.getProperty("db.port"))}); 

 dataSource.setUser((String) propertySource.getProperty("db.username")); 

 dataSource.setPassword((String) propertySource.getProperty("db.password")); 

 return dataSource; 

 }); 

 context.registerBean(ProgrammaticPostgresConnector.class, () -> { 

 DataSource dataSource = context.getBean(DataSource.class); 

 return new ProgrammaticPostgresConnector(dataSource); 

 });

Должно быть:

        context.registerBean("dataSource", ??? <- сюда данные вроде host, port, db, user, pass);
        context.registerBean(ProgrammaticConfigPostgresConnector.class,
            ???, ??? <- сюда "ссылка" на bean, см интерфейс BeanReference
        );

Это не Java-конфиг

spring-course-1/src/test/java/JavaTest.java

Line 9 in b81f632

 ApplicationContext context = new AnnotationConfigApplicationContext("org.example.java"); 

Double Curly Braces Anti Pattern

spring-course-1/src/test/java/ProgrammaticTest.java

Lines 24 to 32 in b8974be

 new HashMap<String, Object>() { 

 { 

 put("serverNames", "${db.serverName}"); 

 put("databaseName", "${db.databaseName}"); 

 put("portNumbers", "${db.port}"); 

 put("user", "${db.username}"); 

 put("password", "${db.password}"); 

 } 

 }

Нехорошо использовать deprecated-методы

spring-course-1/src/test/resources/beans.xml

Lines 14 to 16 in b81f632

 <property name="serverName" value="${db.serverName}"/> 

 <property name="databaseName" value="${db.databaseName}"/> 

 <property name="portNumber" value="${db.port}"/>

assertArrayEquals

spring-course-1/src/test/java/CommonTest.java

Lines 18 to 19 in b81f632

 assertEquals(dataSource.getServerNames()[0], "localhost"); 

 assertEquals(dataSource.getPortNumbers()[0], 5432);

Должно быть:

        assertArrayEquals(dataSource.getServerNames(), new String[]{"localhost"});
        assertArrayEquals(dataSource.getPortNumbers(), new int[]{5432});

Иначе может выясниться, что там не только ваши данные.

desire456 / spring-course-1 Goto Github PK

spring-course-1's People

Watchers

spring-course-1's Issues

Упростить Programmatic Config

Это не Java-конфиг

Double Curly Braces Anti Pattern

Нехорошо использовать deprecated-методы

assertArrayEquals

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs

	context.registerBean(PGSimpleDataSource.class, () -> {
	PropertySource<?> propertySource = context.getBean(PropertySourcesPlaceholderConfigurer.class)
	.getAppliedPropertySources()
	.get("localProperties");
	PGSimpleDataSource dataSource = new PGSimpleDataSource();
	dataSource.setServerNames(new String[]{(String) propertySource.getProperty("db.serverName")});
	dataSource.setDatabaseName((String) propertySource.getProperty("db.databaseName"));
	dataSource.setPortNumbers(new int[]{Integer.parseInt((String) propertySource.getProperty("db.port"))});
	dataSource.setUser((String) propertySource.getProperty("db.username"));
	dataSource.setPassword((String) propertySource.getProperty("db.password"));
	return dataSource;
	});

	context.registerBean(ProgrammaticPostgresConnector.class, () -> {
	DataSource dataSource = context.getBean(DataSource.class);
	return new ProgrammaticPostgresConnector(dataSource);
	});

	new HashMap<String, Object>() {
	{
	put("serverNames", "${db.serverName}");
	put("databaseName", "${db.databaseName}");
	put("portNumbers", "${db.port}");
	put("user", "${db.username}");
	put("password", "${db.password}");
	}
	}

	<property name="serverName" value="${db.serverName}"/>
	<property name="databaseName" value="${db.databaseName}"/>
	<property name="portNumber" value="${db.port}"/>

	assertEquals(dataSource.getServerNames()[0], "localhost");
	assertEquals(dataSource.getPortNumbers()[0], 5432);