desura / desura-app Goto Github PK

Issue by Jookia from Thursday Nov 17, 2011 at 06:54 GMT
Originally opened as desura/Desurium#3

Python2 is named python2 and Python3 is named python on my system for example.

A script to fix cef's cef_create_projects.sh is at http://sprunge.us/XeXU , yet this problem persists in all scripts (such as in depot_tools) that use python directly.

A fix to this would be to call python by $PYTHON and have a script set the environmental variable before the scripts are run.

Issue by yurikoles from Sunday Jan 22, 2012 at 13:05 GMT
Originally opened as desura/Desurium#38

Small change in README file and initial install-deps.sh

yurikoles included the following code: https://github.com/desura/Desurium/pull/38/commits

Issue by Jookia from Monday Jan 23, 2012 at 09:14 GMT
Originally opened as desura/Desurium#42

Tada! This means you should see popups on Linux. testpopup works.

Jookia included the following code: https://github.com/desura/Desurium/pull/42/commits

Issue by Jookia from Thursday Nov 24, 2011 at 20:08 GMT
Originally opened as desura/Desurium#22

It's 7AM, I really don't want to explain it all. It's only a small diff, so just go through it, please?

Jookia included the following code: https://github.com/desura/Desurium/pull/22/commits

Issue by boskee from Saturday Jan 28, 2012 at 07:28 GMT
Originally opened as desura/Desurium#47

Updated cURL to version 7.21.5 and c-ares to 1.7.5. Fixes Issue #44: cURL needs to be updated to at least 7.21.5 as 7.21.4 won't compile on Debian/Ubuntu because of no SSLv2 support

boskee included the following code: https://github.com/desura/Desurium/pull/47/commits

Issue by Jookia from Friday Nov 25, 2011 at 14:00 GMT
Originally opened as desura/Desurium#23

It'd be nice to have per-user game storage in $XDG_DATA_HOME (~/.local/share), instead of /opt/desura/common.

This is just an idea, and I'd like feedback and comments as the current system works fine.

Implementing it would probably best be done as a compile-time option for package maintainers or sysadmins, but then the official Desura website would have to provide two versions if both were to exist.

Issue by miloongithub from Sunday Jan 22, 2012 at 12:19 GMT
Originally opened as desura/Desurium#37

• removed `function' keyword from function declarations for portability
• fixed desktop shortcut permission
• changed desura hardwired binary path to DESURAEXEC variable
• redirection typo (?) cleaned

miloongithub included the following code: https://github.com/desura/Desurium/pull/37/commits

Issue by sadam36 from Saturday Jan 28, 2012 at 18:29 GMT
Originally opened as desura/Desurium#48

Hi,
I saw that 'install-deps.sh' has no Arch Linux option, so I tried to wrote mine. After that I wanted to test it, so tried to build Desurium. Third party built without problems, but I got an error while running build_lin/build.sh:

Traceback (most recent call last):
  File "../src/third_party/gyp/gyp", line 18, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "/home/sadam/Desurium/src/third_party/gyp/pylib/gyp/__init__.py", line 471, in main
    options.circular_check)
  File "/home/sadam/Desurium/src/third_party/gyp/pylib/gyp/__init__.py", line 111, in Load
    depth, generator_input_info, check, circular_check)
  File "/home/sadam/Desurium/src/third_party/gyp/pylib/gyp/input.py", line 2371, in Load
    ValidateTargetType(target, target_dict)
  File "/home/sadam/Desurium/src/third_party/gyp/pylib/gyp/input.py", line 2084, in ValidateTargetType
    (target, target_type, '/'.join(VALID_TARGET_TYPES)))
Exception: Target ../src/third_party/libs.gyp:gtk#target has an invalid target type 'settings'.  Must be one of executable/loadable_module/static_library/shared_library/none.

I wanted to check if that's not dependencies fault, so I switched to Fedora (16), ran 'install-deps.sh'. After that I tried to build third party, and got problems with curl and wxWidgets.

• Curl gave me missing stropts.h.
  I ran: yum provides */stropts.h and got arm-gp2x-linux-glibc-2.3.6-9.fc15.noarch. Arm - strange... But installing it fixed problem.
• wxWidgets gave me:
  make: *** No rule to make target /usr/lib/glib-2.0/include/glibconfig.h', needed by monodll_utilscmn.o'. Stop. And I'm not sure how I can fix it.

I don't know if that's a bug, or I am doing something wrong, but help would be appreciated :)

Also I saw that link branding-> branding_default is made, so line "Copy branding_default in src to src/branding" in readme is probably no longer needed. Also lines for installing dependencies could be changed to just running install-deps.sh.

Issue by Jookia from Tuesday Nov 22, 2011 at 00:24 GMT
Originally opened as desura/Desurium#15

A temporary fix until crypto is removed. Only tested on my system.

Jookia included the following code: https://github.com/desura/Desurium/pull/15/commits

Issue by Jookia from Thursday Dec 01, 2011 at 22:13 GMT
Originally opened as desura/Desurium#25

Why is the updater needed? Maybe it should be removed since package maintainers should be doing it..

Issue by Jookia from Sunday Nov 20, 2011 at 14:26 GMT
Originally opened as desura/Desurium#13

I also removed the #if 0s from the patch as that actually broke the build, I haven't tested this in Windows yet, so it may still be needed. Further testing is needed.

Jookia included the following code: https://github.com/desura/Desurium/pull/13/commits

Issue by naryl from Tuesday Nov 22, 2011 at 00:36 GMT
Originally opened as desura/Desurium#16

The current build system which produces a distribution which should work everywhere is actually only useful for a rare and special case when the user downloads it from the Desura web site. I suggest to reserve it for the project maintainer (Lodle) so that

1. Other developers and package maintainers won't have to deal with occasionally forgotten or outdated build scripts
2. Lodle won't have to spend time maintaining the scripts so they would work for everyone when they do a lot of extra actions not required for either contributors or package maintainers.

Instead we should implement a simple build system which should only use system libraries which would simplify work of contributors and package maintainers (who would currently have to clean up all the bundled libs and fix scripts which build them).

Issue by Jookia from Thursday Nov 17, 2011 at 21:10 GMT
Originally opened as desura/Desurium#10

The Python 3 Fix allows you to build when your Python 3 executable is 'python' and Python 2 executable is 'python2'. It works by editing depot_tools using the patch script and creating a folder with a link to Python 2 in it and putting it in $PATH before everything, to hijack the 'python' calls. It also includes a 'python_env.sh' file that you should 'source' so you don't have to type in the new $PATH each time you need to use Python 2.

The Cef Build Edit includes a bit in the 'python_env.sh' script so depot_tools is in the $PATH and the gyp Python module is in the $PYTHONPATH.

The Courgette Build Fix and Cef Build Edit both include an edit to their Build*.sh scripts that uses the basename of the directory for the log file, that way instead of getting 'build_lin/chromium/src/cef.log' it'll use 'build_lin/cef.log', since the targets are in subfolders.

I haven't done much testing on this, so the documentation I've included may be a little off (I haven't followed it directly on a clean clone as I'd have to waste a few gigs of bandwidth downloading sources for third party libraries), and it's only been done on my Arch Linux 64bit machine.

Jookia included the following code: https://github.com/desura/Desurium/pull/10/commits

Issue by lodle from Sunday Dec 04, 2011 at 10:11 GMT
Originally opened as desura/Desurium#31

Need to implement tool tips like windows

Issue by boskee from Sunday Jan 29, 2012 at 11:45 GMT
Originally opened as desura/Desurium#49

Desurium is reporting problems while reading free disk space:

(25081, son of 25029) src/static/util/code/UtilLinux.cpp:390 - Free space for '/home/voitek/Projects/desurium/build_out/debug_lin/common/braid-64' could not be determined!
(25081, son of 25029) src/static/util/code/UtilLinux.cpp:390 - Free space for '/home/voitek/Projects/desurium/build_out/debug_lin/.settings' could not be determined!

This is because the actual path that's checked is missing the first slash, eg. it tries to check home/voitek/(...)

Here's the code:

uint64 getFreeSpace(const char* path)
{
    if (!path)
        return -1;

    UTIL::FS::Path p(path, "", false);

    std::vector<std::string> folders;

    for (size_t x=0; x<p.getFolderCount(); x++)
        folders.push_back(p.getFolder(x));

    struct statvfs fsinfo;

    for (size_t x=1; x<=folders.size(); x++)
    {
        UTIL::FS::Path fullP;

        for (size_t y=0; y<folders.size()-x; y++)
            fullP += folders[y];

        std::string szPath = fullP.getFullPath();

        if(statvfs(szPath.c_str(), &fsinfo) != 0)
            continue;

        return (fsinfo.f_bsize * fsinfo.f_bavail); 
    }

    char buffer[1024];
    snprintf(buffer, 1024, "Free space for '%s' could not be determined!", path);
    ERROR_OUTPUT(buffer);
    return -1;
}

The problem is, that std::string szPath = fullP.getFullPath(); never has a chance to prepend that slash, as it only does so if m_absolutePath equals true.

UtilFsPath.cpp:

Path::Path()
{
#ifdef NIX
    m_absolutePath = false;
#endif
}

To fix this, we need to assign fullP.m_absolutePath. So, you should add something like this after UTIL::FS::Path fullP; in UtilLinux.cpp:

        fullP.m_absolutePath = p.m_absolutePath;

Issue by miloongithub from Sunday Jan 22, 2012 at 18:15 GMT
Originally opened as desura/Desurium#39

On GNU/Linux:

1. install game
2. back it (~/desura/common/) up
3. remove it ("remove files" and "remove it from account")
4. restore backup
5. install game from the client

Client won't be able to recognize valid game files. Perhaps there should be also option from backing-up data available from Desurium (but that's other topic).

Issue by Jookia from Thursday Nov 17, 2011 at 20:50 GMT
Originally opened as desura/Desurium#8

Building Desura uses 128 processes and brings my computer to a screeching halt, apparently it's due to the huge amount of IO being used.

Issue by hero1900 from Sunday Jan 22, 2012 at 19:27 GMT
Originally opened as desura/Desurium#41

hero1900 included the following code: https://github.com/desura/Desurium/pull/41/commits

Issue by Jookia from Thursday Nov 17, 2011 at 20:54 GMT
Originally opened as desura/Desurium#9

If you grep 'src/third_party/cef/cef.gyp' you'll see that it requires 'leveldb', which doesn't exist in the Chromium source tree (anymore at least, I read somewhere that it was removed). It also requires other things that aren't there.

Thus it can't build.

Issue by Protektor-Desura from Saturday Jan 21, 2012 at 08:14 GMT
Originally opened as desura/Desurium#32

We should add to the Tools menu under the Desura icon a link that takes you to the web page where it lists all the games you own and all the CDKeys for each game that needs it. There are other ways to get to it but it is pretty buried and if you don't know where it is your likely to miss it.

The URL is:
https://secure.desura.com/cart/cdkeys

It is the same URL for everyone and they just need to be logged in to get the list.

Issue by Protektor-Desura from Saturday Jan 21, 2012 at 08:58 GMT
Originally opened as desura/Desurium#34

The Linux client has a bug where if the directory for a game exists and is empty it gets stuck at "Validating Existing Files". If you cancel out then the client crashes. You have to go in and delete the empty directory for it to be able to download the game.

Issue by Jookia from Tuesday Nov 22, 2011 at 00:48 GMT
Originally opened as desura/Desurium#17

As seen in the (XDG Base Directory Specification)[http://standards.freedesktop.org/basedir-spec/basedir-spec-0.7.html] we should be using $XDG_CONFIG_HOME/desura/ for configuration (this usually ends up being ~/.config/desura/) and $XDG_RUNTIME_DIR/desura for sockets and other runtime things (XDG_RUNTIME_DIR isn't defined on my system, but XDG_CONFIG_HOME is. the specification tells you what to do if they aren't defined, though)

While the Linux client went public, this needs to be done sooner rather than later, seeing as the longer we wait the more of a hassle it will be to switch.

Switching would also allow people to specify the configuration directories using environmental variables, which is a huge bonus. Especially for distros like GoboLinux.

Issue by Jookia from Thursday Nov 17, 2011 at 10:09 GMT
Originally opened as desura/Desurium#6

When trying to build cef I get an exception about being unable to find leveldb's gyp file.

Issue by naryl from Saturday Nov 26, 2011 at 15:16 GMT
Originally opened as desura/Desurium#24

It's the key which makes Desura force update. After successfully updating itself it shows a message box with "Unknown Desura Link: -f."

(Doesn't apply to Desurium)

Issue by boskee from Tuesday Jan 24, 2012 at 06:16 GMT
Originally opened as desura/Desurium#44

cURL needs to be updated to at least 7.21.5 as 7.21.4 won't compile on Debian/Ubuntu because of no SSLv2 support

Issue by Jookia from Wednesday Nov 23, 2011 at 17:32 GMT
Originally opened as desura/Desurium#20

The ones in the latest commits.

Issue by Jookia from Thursday Dec 01, 2011 at 22:15 GMT
Originally opened as desura/Desurium#27

The names are mixed due to the different branding.

Issue by Jookia from Thursday Dec 01, 2011 at 22:27 GMT
Originally opened as desura/Desurium#28

When closing Desurium, I get the error:

09:17:51: Error: Failed to remove lock file '/home/jookia/.cache/desura/applock' (error 2: No such file or directory)

This is because I remove the $XDG_RUNTIME_DIR/desura directory before the lock is deleted.

Issue by Protektor-Desura from Wednesday Jan 25, 2012 at 11:54 GMT
Originally opened as desura/Desurium#46

The Windows client will add games to control panel but it doesn't add the displayed name correctly. You end up with names of "Desura:" over and over for each game installed. If you remove the game using Desura then the Control Panel version isn't removed so you have to go in by hand and remove them from control panel and you get "There was an error removing this do you want to delete this".

Issue by lodle from Sunday Dec 04, 2011 at 09:57 GMT
Originally opened as desura/Desurium#29

http://www.moddb.com/groups/desura/forum/thread/shortcut-of-games-on-desktop/#705641

All Ready implemented on windows. Shouldnt be to hard to add.

Issue by liamdawe from Tuesday Jan 24, 2012 at 10:25 GMT
Originally opened as desura/Desurium#45

I just saw in the commit log using libnotify on linux...isnt that an Ubuntu thing not a Linux thing?

Issue by naryl from Wednesday Nov 23, 2011 at 20:59 GMT
Originally opened as desura/Desurium#21

build.sh now creates a symlink for branding_default or branding_desura depending on --branding-desura key.

naryl included the following code: https://github.com/desura/Desurium/pull/21/commits

Issue by Jookia from Saturday Jan 21, 2012 at 16:04 GMT
Originally opened as desura/Desurium#35

Infact, they may be related. Who knows.

Jookia included the following code: https://github.com/desura/Desurium/pull/35/commits

Issue by lodle from Sunday Dec 04, 2011 at 10:11 GMT
Originally opened as desura/Desurium#30

http://www.moddb.com/groups/desura/forum/thread/unknown-desura-link-f

Issue by Protektor-Desura from Saturday Jan 21, 2012 at 08:25 GMT
Originally opened as desura/Desurium#33

This one is going to be a pain in the behind to find. Consitantly but with no rhyme or reason the Linux client will crash and exit when doing an upload. The Windows version doesn't seem to have this problem. Sometimes it happens immediately when you try and start the upload sometimes it take as long at 10 minutes. It always crashes though before the upload is finished unless it is a small file like under 10 megs. Most updates to games are this small but getting a game up under Linux it always crashes multiple times and I have to resume it.

Less frequent is the crash on download. I have I would say maybe 5% of the time the client will crash on a download both on Windows and Linux.

I do way more uploading and downloading than most do with the client, so I see it all the time, but I am getting reports from developers and users of this issue.

Issue by Jookia from Thursday Nov 17, 2011 at 04:34 GMT
Originally opened as desura/Desurium#1

Right now everything is checked out and built by SVN, but I have Boost (for example) installed in my system. Allowing the use of external dependencies would be good.

Maybe a simple file exporting variables for which external dependencies to checkout and build would be a start? Of course it wouldn't do any detecting, but it'd allow us to manually set it up to use our system's stuff.

Issue by Jookia from Sunday Jan 22, 2012 at 03:28 GMT
Originally opened as desura/Desurium#36

Yeah.

Jookia included the following code: https://github.com/desura/Desurium/pull/36/commits

Issue by Jookia from Thursday Dec 01, 2011 at 22:15 GMT
Originally opened as desura/Desurium#26

It's pretty much a prerequisite to use the GPL license.

Issue by Jookia from Monday Nov 21, 2011 at 03:49 GMT
Originally opened as desura/Desurium#14

Whoops?

Jookia included the following code: https://github.com/desura/Desurium/pull/14/commits

Issue by Jookia from Wednesday Nov 23, 2011 at 17:28 GMT
Originally opened as desura/Desurium#19

Linker errors cause the build to fail. Currently I've commented out the problem code.

Issue by yurikoles from Sunday Jan 22, 2012 at 19:06 GMT
Originally opened as desura/Desurium#40

Install-deps.sh now determines running distribution and runs corresponding installation command. For now support is limited to Debian-based and Fedora.

yurikoles included the following code: https://github.com/desura/Desurium/pull/40/commits

Issue by boskee from Sunday Jan 29, 2012 at 16:10 GMT
Originally opened as desura/Desurium#50

Fixed cairo test in build_out/release_lin/desura

1. It now looks for a correct version of libcairo.so by using findlibs.sh. Previously, it was hardcoded to /usr/lib/libcairo.so
2. Changed CARIO to CAIRO, although I left .ignore_cariotest as is for now, should be changed too!

boskee included the following code: https://github.com/desura/Desurium/pull/50/commits

Issue by miloongithub from Monday Jan 23, 2012 at 23:27 GMT
Originally opened as desura/Desurium#43

extended instruction how to grab cef's lib from "old" client's instance/install

miloongithub included the following code: https://github.com/desura/Desurium/pull/43/commits

Issue by Jookia from Thursday Nov 17, 2011 at 10:30 GMT
Originally opened as desura/Desurium#7

Considering we're suppose to symlink the gef folder to the chromium one, it doesn't seem that the src/third_party/gefs folder should be in this repo.

Issue by Jookia from Saturday Nov 19, 2011 at 01:41 GMT
Originally opened as desura/Desurium#11

As you can see here in this gist, a single error in crypto is breaking almost everything.

src/third_party/crypto/include/secblock.h:32:7: note: void CryptoPP::AllocatorBase<T>::construct(CryptoPP::AllocatorBase<T>::pointer, const T&) [with T = CryptoPP::HuffmanDecoder::LookupEntry, CryptoPP::AllocatorBase<T>::pointer = CryptoPP::HuffmanDecoder::LookupEntry*]
src/third_party/crypto/include/secblock.h:32:7: note: candidate expects 2 arguments, 1 provided

Issue by Jookia from Wednesday Nov 23, 2011 at 17:26 GMT
Originally opened as desura/Desurium#18

Every 5 hours or so (has to be under 6 hours), any files we put in XDG_RUNTIME_DIR (like the locks and sockets) should have their mtime attribute update to avoid being cleaned out. See here for details.

Issue by Jookia from Thursday Nov 17, 2011 at 04:53 GMT
Originally opened as desura/Desurium#2

Currently they don't work. The ones in the readme. If you clone this repo and then follow the instructions exactly you'll see the problem. I'm currently hacking my way through it trying to fix it but I'm not sure if it's just my problem.

Issue by Jookia from Thursday Nov 17, 2011 at 07:37 GMT
Originally opened as desura/Desurium#5

Considering the readme just tells you to write in commands, it seems simpler to wrap them in a shell script and have the user use that does it not?

Issue by Jookia from Sunday Nov 20, 2011 at 09:02 GMT
Originally opened as desura/Desurium#12

It'd be easier to do than copying folders if the branding was specified was a build option.

Issue by Jookia from Thursday Nov 17, 2011 at 07:30 GMT
Originally opened as desura/Desurium#4

The correct version should be the text one from the following URL:

https://www.gnu.org/licenses/gpl-3.0.txt