detaybey / wrapyoutubedl Goto Github PK

I do not have media folders at C:\User\Brian. Consider adding the actual video and music media folders used by the user. It is common for these folders to be customized since many people run their OS on an SSD and keeping their personal files on a storage drive.

Right now the exit prompt shows either always or never according to one boolean option. It would be ideal to show the prompt only when a download or conversion is in progress, or an item is qued for download. It makes little sense to have an exit prompt under normal circumstances.

After a video is downloaded, the file has missing metadata. Using the command line to call youtube-dl, I used the following arguments taken from line 67 of AudioDownloader.cs:

var arguments = string.Format(@"--continue --no-overwrites --restrict-filenames --extract-audio --audio-format mp3 {0} -o ""{1}""", url, destinationPath); //--ignore-errors

after the download, the final line of output is:

[ffmpeg] Post-process file C:\path_to_file\test.mp3 exists, skipping

it seems this is happening because the arguments include the path to filename. Ideally it should create an intermediate file, probably .webm or .m4a or something, then run post tasks, then create the .mp3 file, but if it creates the .mp3 file to begin with you'll get the above error saying the file exists

When switching between export paths on Windows 10, I must restart the app for it to actually apply as the download location. The "Open Containing Folder" feature works as expected however.

Hello, I'm not familiar with the following syntax which throws a build error. I tried removing the ? but then a runtime error is thrown.

StartedDownload?.Invoke(this, e)

Any insight?

PD: Nice work men :D