GithubHelp home page GithubHelp logo

remove-offline-agents's People

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

remove-offline-agents's Issues

Nested foreach loops

Hi I wanted to thank you for your blog post and I found it extremely helpful as someone new to powershell. My ADO agent pool had offline agents accumulating for over a year now and it was a pain to look at!

There is an issue however with your nested foreach loop where the outer loop goes over the OfflineAgent IDs and the inner loop goes over the AgentNames. What ends up happening is that you call the same delete command over and over again for as many OfflineAgents that you have for a single OfflineAgent ID. That won't be an issue if you have a handful of Offline Agents but...I currently have hundreds and I was scratching my head for a bit wondering why each script run would only remove the first OfflineAgent after 5 minutes.

Here's the fixed snippet of the code that still prints out the Agent name but loops correctly:

if ($Agents) {
   $OfflineAgents = ($Agents | Where-Object { $_.status -eq 'Offline'})
   foreach ($OfflineAgent in $OfflineAgents) {
     $AgentName = $OfflineAgent.Name
      Write-Output "Removing: $($AgentName) From Pool: $($AgentPoolName) in Organization: $($OrganizationName)"
      $OfflineAgentsUrl = "https://dev.azure.com/$($OrganizationName)/_apis/distributedtask/pools/$($PoolId)/agents/$($OfflineAgent.id)?api-version=$($ApiVersion)"
      Write-Output "DELETE: $($OfflineAgentsUrl)"
      Invoke-RestMethod -Uri $OfflineAgentsUrl -Method 'Delete' -Headers @{Authorization = "Basic $EncodedPAT"}

      # slow down the request rate to avoid throttling from Azure
      Start-Sleep -Milliseconds 50
   }
 } else {
   Write-Output "No Agents found in $($AgentPoolName) for Organization $($OrganizationName)"
 }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.