GithubHelp home page GithubHelp logo

videbate's People

Contributors

israeldeweb avatar yanivyehu avatar

Watchers

 avatar

videbate's Issues

Create tests for `storage.js`

I'm thinking of locking master from merges that don't have 100% coverage. We are totally in a place where we can afford it. What do you say?

Post integrity on db

before post is being saved on DB, we need to validate that all fathers posts exists on db. for example:

if we want to save post 1 - nothing to check
if want to save post 1:2 - we need to check that post with path 1 exists
if want to save post 1:2:3 - we need to check that post with path 1 :2 exists

How do we get the BBS post ID on `/new`?

Obviously we don't, since the post ID does not exist until the post is published. One possible solution is to change the flow of the core UI, at least when creating a videbate post, to get the ID earlier, either by setting it manually (generating a UUID and using it when saving the document to firestore) or by publishing the post earlier and marking it as hidden until the final publish.

Another option is to save the new post to a secondary index table which links a surrogate ID (serial) to a BBS community ID and a videbate ID (materialized path of the BBS post IDs). When an item is created the videbate ID will be null, and the server will poll the community's posts and write the data to the posts table when it is found (updating the videbate ID in the index table).

Get `videbate.js` to work with `bbs-common`

This should be very very easy. If you think it takes more than an hour - don't do it. Maybe we will just delete videbate.js, since without this step it is fundamentally broken.

Document env variables

The storage.js module requires a couple of env variables that are not documented in README.md.

It's also a good idea to check and give better error messages for missing env vars (dotenv probably has something that does it). If this is very easy, we can do it as part of this ticket. Otherwise just open a new one and we will get to it when and if.

correct setup of env variables on gcp

looks like dotenv lib is good for local dev, but when deploying to gcp env variables are not loaded to the running process, so need to configure env variables on the service itself (like being done for other services we have).

we need to agree on a way to do it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.